Regression: use_build_context_synchronously false positives on certain conditionals

[mernen]

Example:

import 'package:flutter/material.dart';

class TestState extends State {
  final _somethingElse = false;

  void testLeftHandMounted() async {
    await Future.value(0);
    if (!mounted || _somethingElse) return;

    Navigator.pop(context); // bogus use_build_context_synchronously (3.13 only)
  }

  void testRightHandMounted() async {
    await Future.value(0);
    if (_somethingElse || !mounted) return;

    Navigator.pop(context); // bogus use_build_context_synchronously (3.13, beta, master)
  }

  @override
  Widget build(BuildContext context) => const Placeholder();
}

The first test was fixed on unstable builds (still a regression on stable), but the second one remains:

Flutter	testLeftHandMounted	testRightHandMounted
3.7.12	✅	✅
3.10.6	✅	✅
stable (3.13.4)	❌	❌
beta (3.15.0-15.1.pre)	✅	❌
master	✅	❌

The specific version tested for master was Flutter engine 10c480310926d7e04a77ba8a04d321f9d225a545.

[pq]

@srawlins

[srawlins]

Thanks for the excellent bug report!

[srawlins]

Fixed at HEAD.