This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
fix issue in const error handling #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
pq
reviewed
Jun 27, 2018
bwilkerson
approved these changes
Jun 27, 2018
|
% travis failure this looks awesome. Thanks for the quick follow-up! |
|
It looks like some errors can not be used to create |
|
@a14n: should I push out a new release w/ this fix? |
|
@pq go for a new release (dart-lang/sdk#33647 been related to analyzer it shouldn't impact linter) |
|
Will do. Thanks! |
The messaging is poor, but that happens when the error expects arguments and none are provided. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.