Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer_mixin support for nonfunction-type-aliases #2523

Merged
merged 1 commit into from
Mar 18, 2021
Merged

prefer_mixin support for nonfunction-type-aliases #2523

merged 1 commit into from
Mar 18, 2021

Conversation

pq
Copy link
Member

@pq pq commented Mar 17, 2021 •
edited
Loading

@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@pq pq marked this pull request as draft March 17, 2021 19:57
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 95.821% when pulling 58876f4 on prefer_mixin_nonfunction-type-aliases into bf95e79 on master.

srawlins
srawlins reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha wow, there you go.

@pq pq changed the title (WIP) support for nonfunction-type-aliases prefer_mixin support for nonfunction-type-aliases Mar 17, 2021
@pq pq marked this pull request as ready for review March 17, 2021 22:13
@pq pq requested review from srawlins and bwilkerson March 18, 2021 18:16
@pq pq merged commit e592240 into master Mar 18, 2021
@pq pq deleted the prefer_mixin_nonfunction-type-aliases branch March 18, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwilkerson bwilkerson bwilkerson approved these changes

@srawlins srawlins Awaiting requested review from srawlins

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pq @coveralls @srawlins @bwilkerson