This repository has been archived by the owner on Nov 20, 2024. It is now read-only.
=> Dart 3.0! #4267
Merged
=> Dart 3.0! #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
linter-set-recommended
jacob314
reviewed
Apr 10, 2023
| @@ -193,4 +174,12 @@ class _Visitor extends SimpleAstVisitor<void> { | |||
|
|
|||
| return true; | |||
| } | |||
|
|
|||
| static TokenType _invertedTokenType(TokenType type) => switch (type) { | |||
There was a problem hiding this comment.
Bonus points for being generated by our assist. 🥳
There was a problem hiding this comment.
For points, you could make this an extension on TokenType 😄
bwilkerson
approved these changes
Apr 12, 2023
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 23, 2023
* dart 3.0 migration * fixed dangling library
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With (internal) cl/523481067 landed and server on 3.0, I think we're actually good to go here and this is safe to land.
/cc @bwilkerson @srawlins