Add notes regarding migrating from pedantic #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
reviewed
May 21, 2021
README.md
Outdated
| @@ -64,8 +64,20 @@ You can customize the pre-defined lint sets, both to disable one or more of the | |||
| lints included, or to add additional lints. For details see [customizing static | |||
| analysis]. | |||
|
|
|||
| ## Migrating from the pedantic package | |||
|
|
|||
| In migrating from the pre-defined lint sets provided by the [pedantic package], | |||
There was a problem hiding this comment.
Is this delta w/ the latest pedantic? (I can't recall.) If not, we should probably specify a version?
README.md
Outdated
| included in the pre-defined lint sets provided by the lints package: | ||
| `always_declare_return_types`, `prefer_single_quotes`, | ||
| `sort_child_properties_last`, `unawaited_futures`, `unsafe_html`, and | ||
| `use_full_hex_values_for_flutter_colors`. To keep any of these lints enabled, |
There was a problem hiding this comment.
Maybe we can point out that sort_child_properties_last and use_full_hex_values_for_flutter_colors are now in flutter_lints?
devoncarew
approved these changes
May 21, 2021
README.md
Outdated
| @@ -64,8 +64,20 @@ You can customize the pre-defined lint sets, both to disable one or more of the | |||
| lints included, or to add additional lints. For details see [customizing static | |||
| analysis]. | |||
|
|
|||
| ## Migrating from the pedantic package | |||
There was a problem hiding this comment.
the pedantic package => package:pedantic ?
README.md
Outdated
| ## Migrating from the pedantic package | ||
|
|
||
| In migrating from the pre-defined lint sets provided by the [pedantic package], | ||
| you get additional static analysis coverage from 29 additional lints. There |
There was a problem hiding this comment.
nit: I'd just say 'additional' once here
parlough
reviewed
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37