-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes regarding migrating from pedantic #41
Conversation
README.md
Outdated
@@ -64,8 +64,20 @@ You can customize the pre-defined lint sets, both to disable one or more of the | |||
lints included, or to add additional lints. For details see [customizing static | |||
analysis]. | |||
|
|||
## Migrating from the pedantic package | |||
|
|||
In migrating from the pre-defined lint sets provided by the [pedantic package], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this delta w/ the latest pedantic? (I can't recall.) If not, we should probably specify a version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest
README.md
Outdated
included in the pre-defined lint sets provided by the lints package: | ||
`always_declare_return_types`, `prefer_single_quotes`, | ||
`sort_child_properties_last`, `unawaited_futures`, `unsafe_html`, and | ||
`use_full_hex_values_for_flutter_colors`. To keep any of these lints enabled, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can point out that sort_child_properties_last
and use_full_hex_values_for_flutter_colors
are now in flutter_lints
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
README.md
Outdated
@@ -64,8 +64,20 @@ You can customize the pre-defined lint sets, both to disable one or more of the | |||
lints included, or to add additional lints. For details see [customizing static | |||
analysis]. | |||
|
|||
## Migrating from the pedantic package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pedantic package
=> package:pedantic
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
README.md
Outdated
## Migrating from the pedantic package | ||
|
||
In migrating from the pre-defined lint sets provided by the [pedantic package], | ||
you get additional static analysis coverage from 29 additional lints. There |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd just say 'additional' once here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great to include, thanks! I particularly like to include
always_declare_return_types
, prefer_single_quotes
, and sort_child_properties_last
and I imagine others who used pedantic
previously will as well :)
Fixes #37