Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention dart:async unawaited #53

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Mention dart:async unawaited #53

merged 1 commit into from
Sep 28, 2021

Conversation

davidmorgan
Copy link
Contributor

For people migrating from pedantic, point them to the new unawaited in dart_async.

For people migrating from `pedantic`, point them to the new `unawaited` in `dart_async`.
@pq
Copy link
Member

pq commented Sep 24, 2021

Nice! Should we wait until the API is widened to support nullable futures?

@davidmorgan
Copy link
Contributor Author

Don't mind, this is useful for people to know anyway I guess :)

Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pq
Copy link
Member

pq commented Sep 27, 2021

Aside: when the APIs are compatible, maybe we should consider deprecating unawaited in pedantic?

@davidmorgan
Copy link
Contributor Author

The API change landed :)

I just marked the whole pedantic package 'discontinued', we'll see if that is enough to reduce usage.

@pq pq merged commit d472642 into main Sep 28, 2021
@pq pq deleted the davidmorgan-patch-1 branch September 28, 2021 18:19
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 18, 2024
For people migrating from `pedantic`, point them to the new `unawaited` in `dart_async`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants