-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lints for v2.0 #72
Conversation
pubspec.yaml
Outdated
|
||
environment: | ||
sdk: '>=2.12.0 <3.0.0' | ||
sdk: '>=2.17.0-0 <3.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to verify that this is the lower bound that we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since nobody has raised any concerns about this in the email thread, I am assuming this constraint is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a non-stable lower bound is OK. It has the added benefit that we can publish prior to 2.17 stable going out, and pub.dev will show the package as a "pre-stable release" until the exact moment 2.17 stable launches.
But rather than using -0
we should perhaps use the build number for the lowest release that supports all the lints that we're including here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am going to set this to 2.17.0-206.0.dev
, which is the lowest version that contains all autofixes for the lints we are enabling.
For reference, the last autofix was added in dart-lang/sdk@0d130c3. This version has not rolled into Flutter yet, but should be in the next few hours.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
@@ -8,13 +8,15 @@ linter: | |||
- camel_case_extensions | |||
- camel_case_types | |||
- curly_braces_in_flow_control_structures | |||
- depend_on_referenced_packages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto fix for this one is still under discussion, see #42.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are going to ship this without an autofix.
🚀 |
I am just waiting on |
See https://github.com/dart-lang/lints/projects/1.
Fixes #64
Fixes #42
Fixes #23
Fixes #71
Fixes #61
Fixes #66
Fixes #68
Fixes #67
Fixes #70
Fixes #58