Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Document how to do build.dart that downloads a binary #157

Closed
Tracked by #882
dcharkes opened this issue Oct 14, 2023 · 2 comments · Fixed by #1860
Closed
Tracked by #882

[doc] Document how to do build.dart that downloads a binary #157

dcharkes opened this issue Oct 14, 2023 · 2 comments · Fixed by #1860
Labels
package:native_assets_cli
Milestone
Native Assets v1.0

Comments

@dcharkes
Copy link
Collaborator

Or maybe even add an example? (But where do we host the binaries for the example?)

Context:
@Piinks
Copy link

Piinks commented Oct 16, 2023

where do we host the binaries for the example?

Could we pick one from CIPD just for the purposes of an example? For the framework we download https://chrome-infra-packages.appspot.com/p/skia/tools/goldctl for every commit in infra to run golden file tests

@dcharkes dcharkes mentioned this issue Nov 6, 2023
Open
@dcharkes dcharkes mentioned this issue Jan 9, 2024
Open
8 tasks
@dcharkes
Copy link
Collaborator Author

Some example: #996

@dcharkes dcharkes added this to the Native Assets v1.0 milestone Aug 30, 2024
This was referenced Jan 3, 2025
Closed
Merged
auto-submit bot pushed a commit that referenced this issue Jan 9, 2025
@dcharkes
[native_assets_cli] Add example for downloading assets (#1860)
43ad99c 
Add an example for how to download assets in a hook which are built on GitHub CI.

Design approach:

* `tool/build.dart` uses `package:native_toolchain_c`.
* GitHub action that publishes artifacts on a tag (not the package release tag).
* `hook/build.dart` downloads the artifacts.
* `tool/generate_asset_hashes.dart` generates hashes that are used in `hook/build.dart` to check download integrity.

GitHub actions mostly cargo culted from:

* https://github.com/dart-lang/i18n/blob/83e8d08568e26888dc0252c89f5d1faf92052e44/.github/workflows/intl4x_artifacts.yml

Closes: #157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:native_assets_cli
Projects
Native Assets
Status: Done
Milestone
Native Assets v1.0
Development

Successfully merging a pull request may close this issue.

[native_assets_cli] Add example for downloading assets dart-lang/native
2 participants
@dcharkes @Piinks