package:objective_c #1061
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,8 +61,12 @@ jobs: | |
| - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 | ||
| with: | ||
| sdk: 3.3.0 | ||
| - uses: subosito/flutter-action@2783a3f08e1baf891508463f8c6653c258246225 | ||
| with: | ||
| flutter-version: 3.19.0 | ||
| channel: 'stable' | ||
| - name: Install dependencies | ||
| run: flutter pub get | ||
|
There was a problem hiding this comment. Shouldn't the majority of steps not be able to run in Dart standalone? In other words, developers working on FFIgen on Linux/Windows should be able to run things on Dart standalone right? Only the ObjectiveC tests, which only run on MacOS, require Flutter? Can we keep the Windows and Linux configs on Dart standalone? (The JNIgen yaml file only has pub for the examples, not for analyzing package:jnigen, etc.) There was a problem hiding this comment. The Linux/Windows tests can run without flutter, but pub get fails because of the package:objective_c dev dependency. I don't know of a way of declaring that dependency only for mac/ios. https://github.com/dart-lang/native/actions/runs/8593210918/job/23544623224 |
||
| - name: Install libclang-14-dev | ||
| run: sudo apt-get install libclang-14-dev | ||
| - name: Build test dylib and bindings | ||
|
|
@@ -82,8 +86,12 @@ jobs: | |
| - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 | ||
|
There was a problem hiding this comment. You can remove this now, since it's going to be included in the |
||
| with: | ||
| sdk: 3.3.0 | ||
| - uses: subosito/flutter-action@2783a3f08e1baf891508463f8c6653c258246225 | ||
| with: | ||
| flutter-version: 3.19.0 | ||
| channel: 'stable' | ||
| - name: Install dependencies | ||
| run: flutter pub get | ||
| - name: Build test dylib and bindings | ||
| run: dart test/setup.dart | ||
| - name: Run VM tests | ||
|
|
@@ -115,8 +123,12 @@ jobs: | |
| - uses: dart-lang/setup-dart@fedb1266e91cf51be2fdb382869461a434b920a3 | ||
|
|
||
| with: | ||
| sdk: 3.3.0 | ||
| - uses: subosito/flutter-action@2783a3f08e1baf891508463f8c6653c258246225 | ||
| with: | ||
| flutter-version: 3.19.0 | ||
| channel: 'stable' | ||
| - name: Install dependencies | ||
| run: flutter pub get | ||
| - name: Build test dylib and bindings | ||
| run: dart test/setup.dart | ||
| - name: Run VM tests | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done