[swift2objc] Support the async annotation
#1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamappelbe
commented
Dec 3, 2024
|
|
||
| String generateAnnotations(Declaration decl) { | ||
| final annotations = StringBuffer(); | ||
| if (decl is CanAsync && (decl as CanAsync).async) { |
There was a problem hiding this comment.
Promotion isn't working here for some reason, so need the as.
Ideally I'd be able to do this with generics, like String generateAnnotations<T extends CanAsync, CanThrow> (T decl) {, but Dart doesn't allow that yet: dart-lang/language#2709
HosseinYousefi
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented in pretty much exactly the same way as
throws. Added aCanAsyncinterface, started parsing the annotation inparseFunctionInfo, and added the annotation to the generated code. The wrapper method gets anasyncannotation, and when invoking the wrapped method it mustawaitthe result.Also like
throws, there are edge cases whereasyncAPIs can't be marked with@objc. Support for these edge cases will be implemented later. See #1778Fixes #1773