-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[swift2objc] Support Protocols #1832
base: main
Are you sure you want to change the base?
Conversation
Extension support (#1815) might need to be added to implement default initialisation functionality |
PR HealthBreaking changes ✔️
Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
If there's a detail of this PR that will require a whole lot of extra effort to implement, just file a bug (or comment on an existing bug) and leave a TODO in the code to finish that work later. You don't have to do the whole feature in one PR. This means you can land your PRs quicker, and it also makes them easier for me to review because the individual PRs will be smaller and simpler. |
Tests succeed and necessary TODOs have been placed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to split out the AssociatedType
stuff into a follow-up PR? I think that would simplify this PR a lot, and make it easier to review.
Does this PR do any new code gen, or is it just parsing at this stage? If it supports code gen, you'll need to add an integration test.
It is possible, but I felt that it was more of a stub than something that needed its own PR.
It will need some code gen, since protocols can be exported to Objective-C. However, during the gsoc period, I noticed I'll try to work on both over the week. The new PR will give the opportunity to merge |
Closes #1828
From https://docs.swift.org/swift-book/documentation/the-swift-programming-language/protocols/#Protocol-Extensions:
This pull request adds support for parsing protocols by achieving the following:
associatedType
s