Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ffigen] Disable enum warning for ObjC #1859

Merged
merged 1 commit into from
Jan 5, 2025
Merged

[ffigen] Disable enum warning for ObjC #1859

merged 1 commit into from
Jan 5, 2025

Conversation

liamappelbe
Copy link
Contributor

This warning is only relevant on Windows, so we don't need it for ObjC, which is only supported on iOS/macOS.

Fixes #1817

Copy link

github-actions bot commented Jan 3, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
ffigen Breaking 16.0.0 17.0.0-wip 17.0.0 ✔️
API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
ffigen Type
AstNode
Visitation
Visitor
BindingType
NoLookUpBinding
Binding
Writer
SymbolAddressWriter
EnumClass
EnumConstant
UniqueNamer
ObjCBuiltInFunctions
ObjCImport
Parameter
ObjCMsgSendFunc
ObjCMsgSendVariant
ObjCMsgSendVariantFunc
FunctionType
ObjCInternalGlobal
ObjCBlock
ObjCListenerBlockTrampoline
Func
LookUpBinding
LibraryImport
BindingString
BindingStringType
ObjCInterface
ObjCMethod
ObjCProperty
ObjCMethodKind
ObjCMethodOwnership
ObjCMethodFamily
ObjCProtocol
ObjCCategory
Struct
Compound
CompoundMember
CompoundType
Union
MacroConstant
Constant
UnnamedEnumConstant
Global
Typealias
PointerType
ImportedType
ConfigSpec
ConfigValue

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_assets_builder/test_data/native_dynamic_linking/bin/native_dynamic_linking.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@liamappelbe liamappelbe merged commit ab7872c into main Jan 5, 2025
29 of 30 checks passed
@liamappelbe liamappelbe deleted the enumwarn branch January 5, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Seemingly incorrect warning for Foundation enums
2 participants