[hooks_runner] Don't report immutable Dart sources as dependencies

[dcharkes]

Closes: #2290

Shaves 50ms off a fully cached flutter build for flutter create --template package_ffi's example project. (See #2290.)

[github-actions]

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

[github-actions]

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

[github-actions]

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbols

License Headers ✔️

// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers

Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

[goderbauer]

LGTM

[coveralls]

coverage: 83.686% (+0.004%) from 83.682%
when pulling 2204c18 on skip-pub-cached-files-in-deps
into fe3094e on main.

[sigurdm]

I think we store the pub cache in package_config.json.

You could check if that is a prefix of the package path.

But remember that a cached package potentially can depend on a path-dependency, and thus be mutable. Perhaps you need to calculate the transitive dependency closure via package_graph.json...

[dcharkes]

We get all Dart sources in a list, and I'm just filtering out the ones in the pub cache.

[sigurdm]

Right - what I'm saying is that your filter is imprecise (having false positives). You don't want lib/src/hosted/pub.dev/my_file.dart to be assumed immutable.

Rather you could look up package_config.json['pubCache'] And see if the file is p.within that url.