-
Notifications
You must be signed in to change notification settings - Fork 79
[jni] Fix the context when using multiple flutter engines #2494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
PR HealthBreaking changes ✔️
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with |
dbbcc31
to
9eb6750
Compare
cf24d52
to
ea24e4d
Compare
Uses a map on the Java side to store all the plugin instances with the key of engineId. On the Dart side, we use the engineId to access to correct Flutter Engine's context even when there are multiple.
Fetching activity is now exposed via a stream that users will listen to instead of a single cached one. Flutter users will have to use a
StreamBuilder
or similar to access activity this way.