Skip to content

Conversation

liamappelbe
Copy link
Contributor

Split protocol building stuff into a $Builder class and generate bindings for the protocol's instance methods. This allows the user to invoke methods on the protocol instance.

Fixes #2492

Copy link

github-actions bot commented Oct 15, 2025

PR Health

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
objective_c Breaking 8.1.0 9.0.0-dev.0 9.0.0 ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ⚠️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources
objective_c _FinalizablePointer internal.dart::_ObjCReference::new::_finalizable

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

@coveralls
Copy link

coveralls commented Oct 15, 2025

Coverage Status

coverage: 92.256% (+0.3%) from 91.972%
when pulling 14ccdcd on ffigen_proto_inst
into f7c7d52 on main.

@liamappelbe liamappelbe marked this pull request as ready for review October 15, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ffigen] Obj-C protocols: static getter can't be accessed through an instance?

2 participants