Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Android NDK API version #49

Merged
merged 3 commits into from
May 23, 2023
Merged

Add Android NDK API version #49

merged 3 commits into from
May 23, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented May 22, 2023 •
edited
Loading

Enables the launcher (Flutter SDK) to pass the Android NDK API level.

Addresses the launcher part of

Also, makes all test that expect FormatExceptions actually check the content.

@dcharkes dcharkes requested a review from HosseinYousefi May 22, 2023 18:20
@coveralls
Copy link

coveralls commented May 22, 2023 •
edited
Loading

Coverage Status

coverage: 99.401% (-0.07%) from 99.472%
when pulling 828685c on ndk-version
into 0c9079f on main.

HosseinYousefi
HosseinYousefi approved these changes May 23, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯 Thanks @dcharkes!

pkgs/c_compiler/test/cbuilder/cbuilder_cross_android_test.dart Outdated Show resolved Hide resolved
pkgs/c_compiler/test/cbuilder/cbuilder_cross_android_test.dart Outdated Show resolved Hide resolved
@dcharkes dcharkes merged commit 3e1cf18 into main May 23, 2023
@dcharkes dcharkes deleted the ndk-version branch May 23, 2023 10:18
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
Add Android NDK API version (#49)
1127499
@dcharkes dcharkes mentioned this pull request Jul 18, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees
No one assigned
Labels
package:native_assets_cli package:native_toolchain_c
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcharkes @coveralls @HosseinYousefi