Display health and maintenance issues separately.

app/lib/frontend/templates.dart

@@ -238,18 +238,6 @@ class TemplateService {
         break;
     }
 
-    final List suggestions = analysis.suggestions?.map((suggestion) {
-      return {
-        'icon_class': _suggestionIconClass(suggestion.level),
-        'title_html':
-            _renderSuggestionTitle(suggestion.title, suggestion.score),
-        'description_html': markdownToHtml(suggestion.description, null),
-        'suggestion_help_html': getSuggestionHelpMessage(suggestion.code),
-      };
-    })?.toList();
-    final hasIssues =
-        analysis.suggestions?.any((s) => s.isError || s.isWarning) ?? false;
-
     List<Map> prepareDependencies(List<PkgDependency> list) {
       if (list == null || list.isEmpty) return const [];
       return list.map((pd) => {'row_html': _renderAnalysisDepRow(pd)}).toList();
@@ -285,9 +273,12 @@ class TemplateService {
               ?.join(', ') ??
           '<i>unsure</i>',
       'platforms_reason_html': markdownToHtml(analysis.platformsReason, null),
-      'hasSuggestions': suggestions != null && suggestions.isNotEmpty,
-      'suggestions_label': hasIssues ? 'Issues and suggestions' : 'Suggestions',
-      'suggestions': suggestions,
+      'analysis_suggestions_html':
+          _renderSuggestionBlockHtml('Analysis', analysis.panaSuggestions),
+      'health_suggestions_html':
+          _renderSuggestionBlockHtml('Health', analysis.healthSuggestions),
+      'maintenance_suggestions_html': _renderSuggestionBlockHtml(
+          'Maintenance', analysis.maintenanceSuggestions),
       'has_dependency': hasDependency,
       'dependencies': {
         'has_sdk': hasSdkConstraint,
@@ -305,6 +296,33 @@ class TemplateService {
     return _renderTemplate('pkg/analysis_tab', data);
   }
 
+  String _renderSuggestionBlockHtml(
+      String header, List<Suggestion> suggestions) {
+    if (suggestions == null || suggestions.isEmpty) {
+      return null;
+    }
+
+    final hasIssues = suggestions.any((s) => s.isError || s.isWarning);
+    final label =
+        hasIssues ? '$header issues and suggestions' : '$header suggestions';
+
+    final mappedValues = suggestions.map((suggestion) {
+      return {
+        'icon_class': _suggestionIconClass(suggestion.level),
+        'title_html':
+            _renderSuggestionTitle(suggestion.title, suggestion.score),
+        'description_html': markdownToHtml(suggestion.description, null),
+        'suggestion_help_html': getSuggestionHelpMessage(suggestion.code),
+      };
+    }).toList();
+
+    final data = <String, dynamic>{
+      'label': label,
+      'suggestions': mappedValues,
+    };
+    return _renderTemplate('pkg/analysis_suggestion_block', data);
+  }
+
   Map<String, Object> _pkgShowPageValues(
       Package package,
       List<PackageVersion> versions,

app/lib/shared/analyzer_client.dart

@@ -245,6 +245,11 @@ class AnalysisView {
 
   List<Suggestion> get suggestions => getAllSuggestions(_summary);
 
+  List<Suggestion> get panaSuggestions => _summary?.suggestions;
+  List<Suggestion> get healthSuggestions => _summary?.health?.suggestions;
+  List<Suggestion> get maintenanceSuggestions =>
+      _summary?.maintenance?.suggestions;
+
   double get maintenanceScore => _data?.maintenanceScore ?? 0.0;
 }
 

app/test/frontend/golden/analysis_tab_aborted.html

@@ -112,3 +112,6 @@ <h4>Platforms</h4>
 <blockquote></blockquote>
 
 
+
+
+

app/test/frontend/golden/analysis_tab_http.html

@@ -112,7 +112,9 @@ <h4>Platforms</h4>
 <blockquote><p>No platform restriction found in primary library <code>package:http/http.dart</code>.</p>
 </blockquote>
 
-<h4>Suggestions</h4>
+
+
+<h4>Maintenance suggestions</h4>
 <div class="suggestion-row">
   <div class="suggestion-title">
     <span class="suggestion-icon-info"></span>
@@ -138,6 +140,7 @@ <h4>Suggestions</h4>
   </div>
 </div>
 
+
 <h4>Dependencies</h4>
 <div class="overflow-x">
 <table class="dependency-table">

app/test/frontend/golden/analysis_tab_mock.html

@@ -112,7 +112,8 @@ <h4>Platforms</h4>
 <blockquote><p>All libraries agree.</p>
 </blockquote>
 
-<h4>Issues and suggestions</h4>
+
+<h4>Health issues and suggestions</h4>
 <div class="suggestion-row">
   <div class="suggestion-title">
     <span class="suggestion-icon-danger"></span>
@@ -126,6 +127,8 @@ <h4>Issues and suggestions</h4>
   </div>
 </div>
 
+
+
 <h4>Dependencies</h4>
 <div class="overflow-x">
 <table class="dependency-table">

app/test/frontend/golden/analysis_tab_outdated.html

@@ -101,3 +101,6 @@
 </p>
 
 
+
+
+

app/test/frontend/golden/pkg_show_page.html

@@ -292,6 +292,9 @@ <h4>Platforms</h4>
 <blockquote></blockquote>
 
 
+
+
+
 <h4>Dependencies</h4>
 <div class="overflow-x">
 <table class="dependency-table">

app/test/frontend/golden/pkg_show_page_discontinued.html

@@ -276,6 +276,9 @@ <h3>3. Import it</h3>
 
 
 
+
+
+
     </section>
   </div>
 

app/test/frontend/golden/pkg_show_page_flutter_plugin.html

@@ -280,6 +280,9 @@ <h4>Platforms</h4>
 
 
 
+
+
+
     </section>
   </div>
 

app/test/frontend/golden/pkg_show_page_legacy.html

@@ -278,7 +278,7 @@ <h3>3. Import it</h3>
   Until this is resolved, the package will receive a health and maintenance score of 0.
 </p>
 
-<h4>Issues and suggestions</h4>
+<h4>Analysis issues and suggestions</h4>
 <div class="suggestion-row">
   <div class="suggestion-title">
     <span class="suggestion-icon-danger"></span>
@@ -293,6 +293,9 @@ <h4>Issues and suggestions</h4>
 </div>
 
 
+
+
+
     </section>
   </div>
 

app/test/frontend/golden/pkg_show_page_outdated.html

@@ -280,6 +280,9 @@ <h3>3. Import it</h3>
 
 
 
+
+
+
     </section>
   </div>
 

app/test/frontend/golden/pkg_show_version_page.html

@@ -294,6 +294,9 @@ <h4>Platforms</h4>
 <blockquote></blockquote>
 
 
+
+
+
 <h4>Dependencies</h4>
 <div class="overflow-x">
 <table class="dependency-table">

app/test/frontend/templates_test.dart

@@ -299,7 +299,7 @@ void main() {
             platforms: ['web'],
             platformsReason: 'All libraries agree.',
             health: 0.95,
-            suggestions: [
+            healthSuggestions: [
               new Suggestion.error(SuggestionCode.dartfmtAborted,
                   'Fix `dartfmt`.', 'Running `dartfmt -n .` failed.'),
             ],
@@ -650,6 +650,15 @@ class MockAnalysisView implements AnalysisView {
   @override
   List<Suggestion> suggestions;
 
+  @override
+  List<Suggestion> panaSuggestions;
+
+  @override
+  List<Suggestion> healthSuggestions;
+
+  @override
+  List<Suggestion> maintenanceSuggestions;
+
   @override
   double maintenanceScore;
 
@@ -663,5 +672,8 @@ class MockAnalysisView implements AnalysisView {
     this.devDependencies,
     this.health,
     this.suggestions,
+    this.panaSuggestions,
+    this.healthSuggestions,
+    this.maintenanceSuggestions,
   });
 }

app/views/pkg/analysis_suggestion_block.mustache

@@ -0,0 +1,16 @@
+{{! Copyright (c) 2018, the Dart project authors.  Please see the AUTHORS file
+    for details. All rights reserved. Use of this source code is governed by a
+    BSD-style license that can be found in the LICENSE file. }}
+<h4>{{label}}</h4>
+{{#suggestions}}
+<div class="suggestion-row">
+  <div class="suggestion-title">
+    <span class="{{icon_class}}"></span>
+    {{& title_html}}
+  </div>
+  <div class="suggestion-description">
+    {{& description_html}}
+    {{& suggestion_help_html}}
+  </div>
+</div>
+{{/suggestions}}

app/views/pkg/analysis_tab.mustache

@@ -91,21 +91,9 @@
 <blockquote>{{& platforms_reason_html}}</blockquote>
 {{/show_analysis}}
 
-{{#hasSuggestions}}
-<h4>{{suggestions_label}}</h4>
-{{#suggestions}}
-<div class="suggestion-row">
-  <div class="suggestion-title">
-    <span class="{{icon_class}}"></span>
-    {{& title_html}}
-  </div>
-  <div class="suggestion-description">
-    {{& description_html}}
-    {{& suggestion_help_html}}
-  </div>
-</div>
-{{/suggestions}}
-{{/hasSuggestions}}
+{{& analysis_suggestions_html}}
+{{& health_suggestions_html}}
+{{& maintenance_suggestions_html}}
 
 {{#has_dependency}}
 <h4>Dependencies</h4>