Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -c, --[no-]checked from CLI usage text #1922

Closed
chalin opened this issue Jun 15, 2018 · 9 comments
Closed

Remove -c, --[no-]checked from CLI usage text #1922

chalin opened this issue Jun 15, 2018 · 9 comments

Comments

@chalin
Copy link

chalin commented Jun 15, 2018

From #1807 (comment):

The option --[no-]checked should be removed/replaced.

> pub run -h
Run an executable from a package.

Usage: pub run <executable> [args...]
-h, --help            Print this usage information.
-c, --[no-]checked    Enable runtime type checks and assertions.

Run "pub help" to see global options.

cc @kevmoo @kwalrath

@kevmoo
Copy link
Member

kevmoo commented Jun 15, 2018

Maybe just add --[no-]enable-asserts and hide --checked?

@kevmoo kevmoo modified the milestone: M3 Jun 15, 2018
@kevmoo
Copy link
Member

kevmoo commented Jun 15, 2018

Sorry. This is for pub client, not pkg:test – sorry for the fire drill @grouma

@natebosch
Copy link
Member

In Dart2 strong mode, the checked parameter only controls asserts, but not type checks.

https://api.dartlang.org/dev/2.0.0-dev.63.0/dart-isolate/Isolate/spawnUri.html

--enable-asserts would have the same implementation as --checked today. I'd be fine adding an alias for this and hiding the original.

@natebosch
Copy link
Member

@kevmoo - what should the single character flag be?

@kevmoo
Copy link
Member

kevmoo commented Jun 19, 2018

e? a?

@chalin
Copy link
Author

chalin commented Jun 19, 2018

--enable-asserts would have the same implementation as --checked

In the context of Dart 2, since the old and the new flags have the same effect, how about this: renaming the new flag to --check-asserts and reusing -c as a shorthand.

Of course --no-checked and --checked would be dropped.

@chalin
Copy link
Author

chalin commented Aug 3, 2018

Any update on this?

@kevmoo
Copy link
Member

kevmoo commented Aug 3, 2018

@jakemac53 @natebosch ?

@natebosch
Copy link
Member

Fixed with 9f00679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants