Represent Pubspec.dependencies as a map #1743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up some existing code, but more importantly it makes some algorithms for the new version solver more efficient.
|
There's a plan for a new solver? I'm so excited! |
|
There's not just a plan, there's a working prototype! |
munificent
approved these changes
Nov 27, 2017
lib/src/package.dart
Outdated
| devDependencies.forEach(addToMap); | ||
|
|
||
| Map<String, PackageRange> get immediateDependencies { | ||
| return {}..addAll(dependencies)..addAll(devDependencies) | ||
| // Make sure to add these last so they replace normal dependencies. |
There was a problem hiding this comment.
Putting the comment in the middle of the cascade is kind of weird. How about moving it up and changing "these" -> "overrides"?
lib/src/pubspec.dart
Outdated
| _dependencyOverrides = | ||
| dependencyOverrides == null ? null : dependencyOverrides.toList(), | ||
| dependencyOverrides == null ? null : new Map.fromIterable(dependencyOverrides, key: (range) => range.name), |
nex3
added a commit
that referenced
this pull request
Dec 6, 2017
This cleans up some existing code, but more importantly it makes some algorithms for the new version solver more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some existing code, but more importantly it makes some
algorithms for the new version solver more efficient.