Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn in Flutter plugin validator with implicit flutter sdk dependency #2265

Merged
merged 3 commits into from
Dec 3, 2019
Merged

Warn in Flutter plugin validator with implicit flutter sdk dependency #2265

merged 3 commits into from
Dec 3, 2019

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Nov 26, 2019 •
edited
Loading

Fixes #2264

@sigurdm sigurdm requested a review from jonasfj November 26, 2019 09:29
@sigurdm sigurdm mentioned this pull request Nov 26, 2019
Closed
@jonasfj
Copy link
Member

jonasfj commented Nov 26, 2019

@amirh, any thoughts?

@amirh
Copy link

amirh commented Dec 2, 2019

LGTM

@jonasfj
Copy link
Member

jonasfj commented Dec 2, 2019

@sigurdm, let's figure out how to cherry pick this into Flutter.

@sigurdm sigurdm merged commit ff5ad1e into dart-lang:master Dec 3, 2019
@sigurdm sigurdm deleted the validate_flutter_plugin_format_implicit_constraint branch December 3, 2019 10:22
@vaind vaind mentioned this pull request Aug 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Flutter plugin platforms schema is allowed when no Flutter SDK constraint is set
4 participants
@sigurdm @jonasfj @amirh @googlebot