Skip to content

Commit

Permalink
[dart2wasm] Remove deprecated --name-section flag from `dart compile …
Browse files Browse the repository at this point in the history
…wasm`

Change-Id: I1e1746c408a704d23db1dbf05b554afda667a0ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371540
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
  • Loading branch information
mkustermann authored and Commit Queue committed Jun 14, 2024
1 parent 50e4c57 commit 18ffc28
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 16 deletions.
2 changes: 1 addition & 1 deletion pkg/dart2wasm/tool/compile_benchmark
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ while [ $# -gt 0 ]; do
shift
;;

-g | --no-strip-wasm | --name-section)
-g | --no-strip-wasm)
BINARYEN_FLAGS+=("-g")
shift
;;
Expand Down
16 changes: 1 addition & 15 deletions pkg/dartdev/lib/src/commands/compile.dart
Original file line number Diff line number Diff line change
Expand Up @@ -646,14 +646,6 @@ class CompileWasmCommand extends CompileSubcommandCommand {
'takes precedence over the optimization-level option.',
hide: !verbose,
)
// TODO(kustermann): Remove this flag once flutter no longer uses it.
..addFlag(
'name-section',
defaultsTo: true,
negatable: true,
help: 'Include a name section with printable function names.',
hide: !verbose,
)
..addFlag(
'strip-wasm',
defaultsTo: true,
Expand Down Expand Up @@ -850,13 +842,7 @@ class CompileWasmCommand extends CompileSubcommandCommand {
return compileErrorExitCode;
}

bool strip = true;
if (args.wasParsed('name-section')) {
strip = !args.flag('name-section');
}
if (args.wasParsed('strip-wasm')) {
strip = args.flag('strip-wasm');
}
final bool strip = args.flag('strip-wasm');

if (runWasmOpt) {
final unoptFile = '$outputFileBasename.unopt.wasm';
Expand Down

0 comments on commit 18ffc28

Please sign in to comment.