Skip to content

Commit

Permalink
Remove ErrorResolverTest.
Browse files Browse the repository at this point in the history
Also I noticed that:
1. I forgot to add FunctionDeclarationStatementResolutionTest.
2. During rebase I forgot to actually remove assertImportPrefix().

Change-Id: Ief08be69c609396c1ab9a4c933fd4017fec70af9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/294366
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
  • Loading branch information
scheglov committed Apr 10, 2023
1 parent 8c219a0 commit 255f887
Show file tree
Hide file tree
Showing 7 changed files with 554 additions and 94 deletions.
85 changes: 0 additions & 85 deletions pkg/analyzer/test/generated/resolver_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import 'dart:collection';
import 'package:analyzer/dart/element/element.dart';
import 'package:analyzer/src/dart/resolver/scope.dart';
import 'package:analyzer/src/error/codes.dart';
import 'package:analyzer/src/generated/parser.dart' show ParserErrorCode;
import 'package:analyzer/src/generated/testing/element_factory.dart';
import 'package:test/test.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
Expand All @@ -16,97 +15,13 @@ import '../src/dart/resolution/context_collection_resolution.dart';

main() {
defineReflectiveSuite(() {
defineReflectiveTests(ErrorResolverTest);
defineReflectiveTests(PrefixedNamespaceTest);
defineReflectiveTests(StrictModeTest);
defineReflectiveTests(StrictModeWithoutNullSafetyTest);
defineReflectiveTests(TypePropagationTest);
});
}

@reflectiveTest
class ErrorResolverTest extends PubPackageResolutionTest {
test_breakLabelOnSwitchMember() async {
await assertErrorsInCode(r'''
class A {
void m(int i) {
switch (i) {
l: case 0:
break;
case 1:
break l;
}
}
}''', [
error(CompileTimeErrorCode.BREAK_LABEL_ON_SWITCH_MEMBER, 105, 1),
]);
}

test_breakLabelOnSwitchMember_language218() async {
await assertErrorsInCode(r'''
// @dart = 2.18
class A {
void m(int i) {
switch (i) {
l: case 0:
break;
case 1:
break l;
}
}
}''', [
error(CompileTimeErrorCode.BREAK_LABEL_ON_SWITCH_MEMBER, 121, 1),
]);
}

test_continueLabelOnSwitch() async {
await assertErrorsInCode(r'''
class A {
void m(int i) {
l: switch (i) {
case 0:
continue l;
}
}
}''', [
error(CompileTimeErrorCode.CONTINUE_LABEL_INVALID, 70, 11),
]);
}

test_continueLabelOnSwitch_language218() async {
await assertErrorsInCode(r'''
// @dart = 2.18
class A {
void m(int i) {
l: switch (i) {
case 0:
continue l;
}
}
}''', [
error(CompileTimeErrorCode.CONTINUE_LABEL_INVALID, 86, 11),
]);
}

test_enclosingElement_invalidLocalFunction() async {
await assertErrorsInCode(r'''
class C {
C() {
int get x => 0;
}
}''', [
error(ParserErrorCode.EXPECTED_TOKEN, 26, 3),
error(WarningCode.UNUSED_LOCAL_VARIABLE, 26, 3),
error(HintCode.UNUSED_ELEMENT, 30, 1),
error(ParserErrorCode.MISSING_FUNCTION_PARAMETERS, 32, 2),
]);

var constructor = findElement.unnamedConstructor('C');
var x = findElement.localFunction('x');
expect(x.enclosingElement, constructor);
}
}

@reflectiveTest
class PrefixedNamespaceTest extends PubPackageResolutionTest {
void test_lookup_missing() {
Expand Down
Loading

0 comments on commit 255f887

Please sign in to comment.