Skip to content

Commit

Permalink
Version 3.4.0-84.0.dev
Browse files Browse the repository at this point in the history
Merge 2404a0c into dev
  • Loading branch information
Dart CI committed Jan 27, 2024
2 parents 422d048 + 2404a0c commit 639cf51
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 1 deletion.
13 changes: 13 additions & 0 deletions pkg/analysis_server/lib/src/server/driver.dart
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ class Driver implements ServerStarter {
static const String DISABLE_SERVER_FEATURE_SEARCH =
'disable-server-feature-search';

/// The name of the option to disable the debouncing of `server.status`
/// notifications.
static const String DISABLE_STATUS_NOTIFICATION_DEBOUNCING =
'disable-status-notification-debouncing';

/// The name of the multi-option to enable one or more experiments.
static const String ENABLE_EXPERIMENT = 'enable-experiment';

Expand Down Expand Up @@ -329,6 +334,9 @@ class Driver implements ServerStarter {
}
}

// TODO(brianwilkerson): Pass the following value to the server and
// implement the debouncing when it hasn't been disabled.
// var disableDebouncing = results[DISABLE_STATUS_NOTIFICATION_DEBOUNCING] as bool;
if (analysisServerOptions.useLanguageServerProtocol) {
if (sendPort != null) {
throw UnimplementedError(
Expand Down Expand Up @@ -615,6 +623,7 @@ class Driver implements ServerStarter {
DISABLE_SERVER_EXCEPTION_HANDLING,
DISABLE_SERVER_FEATURE_COMPLETION,
DISABLE_SERVER_FEATURE_SEARCH,
DISABLE_STATUS_NOTIFICATION_DEBOUNCING,
'enable-completion-model',
'enable-experiment',
'enable-instrumentation',
Expand Down Expand Up @@ -821,6 +830,10 @@ class Driver implements ServerStarter {
help: 'disable all completion features', defaultsTo: false, hide: true);
parser.addFlag(DISABLE_SERVER_FEATURE_SEARCH,
help: 'disable all search features', defaultsTo: false, hide: true);
parser.addFlag(DISABLE_STATUS_NOTIFICATION_DEBOUNCING,
negatable: false,
help: 'Suppress debouncing of status notifications.',
hide: true);
parser.addFlag(INTERNAL_PRINT_TO_CONSOLE,
help: 'enable sending `print` output to the console',
defaultsTo: false,
Expand Down
4 changes: 4 additions & 0 deletions pkg/dartdev/lib/src/analysis_server.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ class AnalysisServer {
required this.commandName,
required this.argResults,
this.enabledExperiments = const [],
this.disableStatusNotificationDebouncing = false,
this.suppressAnalytics = false,
});

Expand All @@ -45,6 +46,7 @@ class AnalysisServer {
final String commandName;
final ArgResults? argResults;
final List<String> enabledExperiments;
final bool disableStatusNotificationDebouncing;
final bool suppressAnalytics;

Process? _process;
Expand Down Expand Up @@ -105,6 +107,8 @@ class AnalysisServer {
'--${Driver.CLIENT_ID}=dart-$commandName',
'--disable-server-feature-completion',
'--disable-server-feature-search',
if (disableStatusNotificationDebouncing)
'--disable-status-notification-debouncing',
'--sdk',
sdkPath.path,
if (cacheDirectoryPath != null) '--cache=$cacheDirectoryPath',
Expand Down
1 change: 1 addition & 0 deletions pkg/dartdev/lib/src/commands/analyze.dart
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ class AnalyzeCommand extends DartdevCommand {
cacheDirectoryPath: args['cache'],
commandName: 'analyze',
argResults: args,
disableStatusNotificationDebouncing: true,
enabledExperiments: args.enabledExperiments,
suppressAnalytics: suppressAnalytics,
);
Expand Down
2 changes: 1 addition & 1 deletion tools/VERSION
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@ CHANNEL dev
MAJOR 3
MINOR 4
PATCH 0
PRERELEASE 83
PRERELEASE 84
PRERELEASE_PATCH 0

0 comments on commit 639cf51

Please sign in to comment.