Skip to content

Commit

Permalink
[build/win] Copy dart.lib only if dart binaries were built with expor…
Browse files Browse the repository at this point in the history
…ted symbols.

Flutter dart sdk is built without exported symbols, so no .lib is created.

Addresses flutter/flutter#59687.

Change-Id: Ia79bbb3b0b17377c417ed03fd7737000773bd18b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151660
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
  • Loading branch information
aam authored and commit-bot@chromium.org committed Jun 18, 2020
1 parent 764e728 commit 7d7c129
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ if (target_os != current_os && target_os == "fuchsia") {
deps = [ "../runtime/bin:dart" ]
dart_out = get_label_info("../runtime/bin:dart", "root_out_dir")
sources = [ "$dart_out/${dart_stripped_binary}${executable_suffix}" ]
if (is_win) {
if (is_win && dart_lib_export_symbols) {
sources += [ "$dart_out/dart.lib" ]
}
outputs = [ "$root_out_dir/dart-sdk/bin/{{source_file_part}}" ]
Expand Down

0 comments on commit 7d7c129

Please sign in to comment.