Skip to content

Commit

Permalink
[pkg/ffi] Pass through NDK version
Browse files Browse the repository at this point in the history
Change-Id: Ic1a13d5476a89a6320c77968aacbc721e0480c58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306320
Reviewed-by: Hossein Yousefi <yousefi@google.com>
Commit-Queue: Hossein Yousefi <yousefi@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
  • Loading branch information
dcharkes authored and Commit Queue committed May 30, 2023
1 parent e1ae1b4 commit 94a541a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ vars = {
"matcher_rev": "7e1011772566a8d1817c725a71f091e2791721c8",
"mime_rev": "24448401f621b9e154d165c900a3c8decd8a23f4",
"mockito_rev": "153c145604db47798ee2ff21d2a07aa543fca168",
"native_rev": "3e1cf186069dfef2b4c0a24c30f3893513afa38a",
"native_rev": "45e16dcf59212bda42e753152d3c3cece8f1b10e",
"package_config_rev": "203de2022af26b3ab2bcec18cc49614d9e502897",
"path_rev": "f8d15c2775835fd61ea5e06bb0ab99232f5ec446",
"pool_rev": "a10a0f918802f7b3856cb1f4c78f9073f28a0dd8",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class NativeAssetsBuildRunner {
required Uri workingDirectory,
CCompilerConfig? cCompilerConfig,
IOSSdk? targetIOSSdk,
int? targetAndroidNdkApi,
required bool includeParentEnvironment,
}) async {
assert(_metadata.isEmpty);
Expand Down Expand Up @@ -70,6 +71,7 @@ class NativeAssetsBuildRunner {
dependencyMetadata: dependencyMetadata,
cCompilerConfig: cCompilerConfig,
targetIOSSdk: targetIOSSdk,
targetAndroidNdkApi: targetAndroidNdkApi,
);
final assets = await _buildPackageCached(
config,
Expand Down Expand Up @@ -166,6 +168,7 @@ class NativeAssetsBuildRunner {
required Uri packageRoot,
required Target target,
IOSSdk? targetIOSSdk,
int? targetAndroidNdkApi,
required LinkModePreference linkMode,
required Uri buildParentDir,
CCompilerConfig? cCompilerConfig,
Expand All @@ -178,6 +181,7 @@ class NativeAssetsBuildRunner {
targetIOSSdk: targetIOSSdk,
cCompiler: cCompilerConfig,
dependencyMetadata: dependencyMetadata,
targetAndroidNdkApi: targetAndroidNdkApi,
);
final outDirUri = buildParentDir.resolve('$buildDirName/');
final outDir = Directory.fromUri(outDirUri);
Expand Down

0 comments on commit 94a541a

Please sign in to comment.