Version 3.7.0-209.1.beta

Merge 3.7.0-209.0.dev into beta

.github/ISSUE_TEMPLATE/1_issue_template.md

@@ -1,39 +1,24 @@
 ---
-name: General issue
-about: Report a bug or suggest a feature
-title: 'Create an issue'
+name: Report a general issue.
+about: Report a bug or file a feature request.
 ---
-Thank you for taking the time to file an issue!
 
-This tracker is for issues related to:
+Thank you for taking the time to file an issue! This tracker is for issues related to the Dart analyzer and linter, the Dart core libraries (`dart:async`, `dart:io`, etc.), the Dart native and web compilers, and the Dart VM.
 
-* Dart analyzer and linter
-* Dart core libraries (`dart:async`, `dart:io`, etc.)
-* Dart native and web compilers
-* Dart VM
+When reporting an issue, please include:
 
-Some other pieces of the Dart ecosystem are maintained elsewhere.
-Please file issues in their repository:
+- The Dart version and tooling diagnostic info (`dart info`)
+- Whether you are using Windows, macOS, or Linux (if applicable)
+- Whether you are using Chrome, Safari, Firefox, Edge (if applicable)
 
-* Dart language: https://github.com/dart-lang/language
-* Dart website: https://github.com/dart-lang/site-www
-* Flutter: https://github.com/flutter/flutter
-* Dart and Flutter DevTools: https://github.com/flutter/devtools
-* `dart format`: https://github.com/dart-lang/dart_style
-* `dart test`: https://github.com/dart-lang/test
-* `dart pub`: https://github.com/dart-lang/pub
+Other pieces of the Dart ecosystem are maintained elsewhere; please file issues in their respective repositories:
 
-If you aren't sure, file the issue here, and we'll find the right home for it.
-In your issue, please include:
+- Flutter: https://github.com/flutter/flutter
+- Dart language: https://github.com/dart-lang/language
+- Dart website: https://github.com/dart-lang/site-www
+- `dart format`: https://github.com/dart-lang/dart_style
+- `dart pub`: https://github.com/dart-lang/pub
+- `dart test`: https://github.com/dart-lang/test
+- Dart & Flutter DevTools: https://github.com/flutter/devtools
 
-* Dart version and tooling diagnostic info (`dart info`)
-* Whether you are using Windows, macOS, or Linux (if applicable)
-* Whether you are using Chrome, Safari, Firefox, Edge (if applicable)
-
-Missing some or all of the above might make the issue take longer or
-be impossible to act on.
-
-If you simply have a question, please consider using the listed Dart
-developer communities on the following page:
-
-https://dart.dev/community#join-the-conversation
+If you have a question, instead of using this issue tracker, please refer to the community resources at: https://dart.dev/community#join-the-conversation.

.github/ISSUE_TEMPLATE/2_analyzer.md

@@ -0,0 +1,15 @@
+---
+name: Report an issue with Dart’s static analysis.
+about: >-
+  Create a bug or file a feature request related to Dart's static analysis
+  (including the command line analyzer, the analysis server, and the linter).
+labels: area-analyzer
+---
+
+If this is a bug report, please help us by providing:
+
+- a clear description of the problem you are experiencing
+- the expected and actual behavior, including a repro with the the specific code triggering the issue
+- the Dart SDK version (`dart --version`)
+
+The more information you can provide, the better we can understand and address the issue. Thanks!

.github/ISSUE_TEMPLATE/3_vm.md

@@ -0,0 +1,13 @@
+---
+name: Report an issue with the Dart VM.
+about: Create a bug or file a feature request related to the Dart VM.
+labels: area-vm
+---
+
+If this is a bug report, please help us by providing:
+
+- a clear description of the problem you are experiencing
+- the expected and actual behavior, including a repro with the the specific code triggering the issue
+- the Dart SDK version (`dart --version`)
+
+The more information you can provide, the better we can understand and address the issue. Thanks!

.github/ISSUE_TEMPLATE/4_web.md

@@ -0,0 +1,15 @@
+---
+name: Report an issue related to Dart web.
+about: >-
+  Create a bug or file a feature request related to Dart web (including the web
+  compilers, web libraries, and JS interop).
+labels: area-web
+---
+
+If this is a bug report, please help us by providing:
+
+- a clear description of the problem you are experiencing
+- the expected and actual behavior, including a repro with the the specific code triggering the issue
+- the Dart SDK version (`dart --version`)
+
+The more information you can provide, the better we can understand and address the issue. Thanks!

.github/ISSUE_TEMPLATE/2_cherry_pick.yml → .github/ISSUE_TEMPLATE/5_cherry_pick.yml

@@ -1,12 +1,14 @@
-name: Request a cherry-pick.
-description: Request a patch to be cherry-picked into a release (for contributors use only).
+name: Request a cherry-pick (for contributor use only).
+description: Request a patch to be cherry-picked into a release.
 title: '[CP] <title>'
 labels: ['cherry-pick-review']
+
 assignees:
   - mit-mit
   - athomas
   - vsmenon
   - itsjustkevin
+
 body:
   - type: textarea
     id: commit_hash

.github/ISSUE_TEMPLATE/3_breaking_change.yml → .github/ISSUE_TEMPLATE/6_breaking_change.yml

@@ -1,10 +1,12 @@
-name: Propose a breaking change.
-description: Initiate a breaking change process (for contributors use only!).
+name: Propose a breaking change (for contributor use only).
+description: Initiate a breaking change process.
 title: '[breaking change] <title>'
 labels: ['breaking-change-request']
+
 assignees:
   - itsjustkevin
   - kevmoo
+
 body:
   - type: textarea
     id: change_intent

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1,7 @@
+blank_issues_enabled: true
+contact_links:
+  - name: I want help writing Dart code
+    url: https://stackoverflow.com/tags/dart
+    about: >-
+      Visit Stack Overflow for how-to questions related to using the Dart
+      language, core libraries, or developer tools.

.github/workflows/issue-triage.yml

@@ -21,7 +21,7 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ github.repository_owner == 'dart-lang' }}
     steps:
-      - uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+      - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
         with:
           repository: dart-lang/ecosystem
 

.github/workflows/scorecards-analysis.yml

@@ -24,7 +24,7 @@ jobs:
 
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
         with:
           persist-credentials: false
 
@@ -44,14 +44,14 @@ jobs:
 
       # Upload the results as artifacts (optional).
       - name: "Upload artifact"
-        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
         with:
           name: SARIF file
           path: results.sarif
           retention-days: 5
 
       # Upload the results to GitHub's code scanning dashboard.
       - name: "Upload to code-scanning"
-        uses: github/codeql-action/upload-sarif@6db8d6351fd0be61f9ed8ebd12ccd35dcec51fea
+        uses: github/codeql-action/upload-sarif@f09c1c0a94de965c15400f5634aa42fac8fb8f88
         with:
           sarif_file: results.sarif

.github/workflows/third-party-deps-scan.yml

@@ -22,17 +22,17 @@ jobs:
       contents: read
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
         with:
           persist-credentials: false
       - name: "setup python"
-        uses: actions/setup-python@f677139bbe7f9c59b41e40162b753c062f5d49a3
+        uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b
         with:
           python-version: '3.7.7' # install the python version needed
       - name: "extract deps, find commit hash, pass to osv-scanner"
         run: python .github/extract_deps.py --output osv-lockfile-${{github.sha}}.json
       - name: "upload osv-scanner deps"
-        uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874
+        uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882
         with:
           # use github.ref in name to avoid duplicated artifacts
           name: osv-lockfile-${{github.sha}}

BUILD.gn

@@ -29,9 +29,14 @@ group("most") {
     ":dartanalyzer",
     ":ddc",
     ":runtime",
+    ":samples",
   ]
 }
 
+group("samples") {
+  deps = [ "samples/embedder:all" ]
+}
+
 group("runtime") {
   import("runtime/runtime_args.gni")
 
@@ -86,7 +91,7 @@ group("run_ffi_unit_tests") {
 group("runtime_precompiled") {
   import("runtime/runtime_args.gni")
   deps = [
-    "runtime/bin:dart_precompiled_runtime",
+    "runtime/bin:dartaotruntime",
     "runtime/bin:gen_snapshot",
     "runtime/bin:gen_snapshot($host_toolchain)",
     "runtime/bin:process_test",
@@ -110,7 +115,15 @@ group("create_platform_sdk") {
 }
 
 group("dart2js") {
-  deps = [ "utils/compiler:dart2js" ]
+  import("runtime/runtime_args.gni")
+  if (dart_target_arch != "ia32" && dart_target_arch != "x86") {
+    deps = [
+      ":runtime_precompiled",
+      "utils/compiler:dart2js_sdk_aot",
+    ]
+  } else {
+    deps = [ "utils/compiler:dart2js" ]
+  }
 }
 
 group("dart2wasm_platform") {
@@ -148,7 +161,19 @@ group("dartanalyzer") {
 }
 
 group("ddc") {
-  deps = [ "utils/ddc:dartdevc" ]
+  import("runtime/runtime_args.gni")
+  if (dart_target_arch != "ia32" && dart_target_arch != "x86") {
+    deps = [
+      ":runtime_precompiled",
+      "utils/bazel:kernel_worker_aot",
+      "utils/ddc:dartdevc_aot",
+    ]
+  } else {
+    deps = [
+      "utils/bazel:kernel_worker",
+      "utils/ddc:dartdevc",
+    ]
+  }
 }
 
 group("analysis_server") {
@@ -367,7 +392,7 @@ if (is_fuchsia) {
 
   test_binaries = [
     "dart",
-    "dart_precompiled_runtime",
+    "dartaotruntime",
     "run_vm_tests",
   ]