-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimerCancel1Test fails #170
Comments
This comment was originally written by jrgf...@google.com Fixed in http://codereview.chromium.org/8366038/ Added Fixed label. |
This was referenced Oct 29, 2020
copybara-service bot
pushed a commit
that referenced
this issue
Mar 15, 2023
…dev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0): a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Mar 15, 2023
…elf, webdev, yaml_edit" This reverts commit aab39d3. Reason for revert: Failing some internal builds with the following error http_client_conformance_tests: #wrong_required_libs #wrong_conditional_srcs "required_libs" is currently [] but the code imports ["isolate"]. Original change's description: > [deps] rev args, benchmark_harness, csslib, dartdoc, http, shelf, webdev, yaml_edit > > Revisions updated by `dart tools/rev_sdk_deps.dart`. > > args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): > 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) > > benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): > 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) > > csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): > d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) > > dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): > 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) > > http (https://github.com/dart-lang/http/compare/805a147..74f9d3d): > 74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889) > ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868) > 2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888) > > shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): > 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) > c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) > > webdev (https://github.com/dart-lang/webdev/compare/cfe9753..a15fde0): > a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) > 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) > 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) > c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) > 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) > > yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): > fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints > c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) > > Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023 > Reviewed-by: Konstantin Shcheglov <scheglov@google.com> > Commit-Queue: Konstantin Shcheglov <scheglov@google.com> > Auto-Submit: Devon Carew <devoncarew@google.com> Change-Id: I07b1e6041babc92df359da89eb18c1daf2634d88 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289024 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Siva Annamalai <asiva@google.com> Reviewed-by: Ryan Macnak <rmacnak@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Mar 20, 2023
… shelf, tools, vector_math, webdev, yaml_edit Revisions updated by `dart tools/rev_sdk_deps.dart`. args (https://github.com/dart-lang/args/compare/9305d5a..7a5e3b0): 7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237) benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/a6a0891..725534a): 725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85) clock (https://github.com/dart-lang/clock/compare/5abb481..984642e): 984642e 2023-03-15 Kevin Moore Require Dart 2.19, use and fix recommended lints (#46) csslib (https://github.com/dart-lang/csslib/compare/b671738..d32bdd4): d32bdd4 2023-03-14 Devon Carew refactor the package example (#170) dartdoc (https://github.com/dart-lang/dartdoc/compare/98fa859..7fde7a4): 7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363) protobuf (https://github.com/dart-lang/protobuf/compare/75bc380..b90a4c4): b90a4c4 2023-03-16 Mahdi K. Fard Sort message constructors first. (#807) 00fd975 2023-03-15 Kevin Moore Fix formatting with latest SDK (#808) a67bbb3 2023-03-15 dependabot[bot] Bump actions/cache from 3.2.4 to 3.2.6 (#804) shelf (https://github.com/dart-lang/shelf/compare/e3cfe79..9a792b4): 9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340) c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339) tools (https://github.com/dart-lang/tools/compare/e5353aa..8d18d01): 8d18d01 2023-03-15 Elias Yishak Implement fake ga client (#37) vector_math (https://github.com/google/vector_math.dart/compare/1e4d000..7dec984): 7dec984 2023-03-16 eoineoineoin Add operator== to Quaternion (#288) webdev (https://github.com/dart-lang/webdev/compare/cfe9753..c2c8b17): c2c8b17 2023-03-16 Elliott Brooks (she/her) Prepare Webdev version `3.0.2` for release (#2037) d124fa5 2023-03-16 Elliott Brooks (she/her) Prepare extension for release (#2036) aef715d 2023-03-15 Elliott Brooks (she/her) Prepare DWDS 18.0.1 for release (#2035) a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032) 05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029) 49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026) c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024) 442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021) yaml_edit (https://github.com/dart-lang/yaml_edit/compare/6abc42a..fbc5cb3): fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42) Change-Id: Icf15fc0ffd3ee36e0380751d18fd491de071040e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289881 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by jrgf...@google.com
One timer cancels another, so the cancelled timer's handler should never be called. It is called anyway though.
The text was updated successfully, but these errors were encountered: