-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart:dom indexeddb unable to delete single object by key #1855
Comments
I fixed the problem by adding: _IDBRequestJs delete(_IDBKeyJs key) native '''return this.delete(key);'''; to dom_frog.dart and: _IDBRequestJs delete(_IDBKeyJs key) native '''return this.delete(key);'''; to IDBObjectStore.dart though I'm not sure if I had to do both :) |
This is blocking an internal partner. Let us know if you need any additional information or context. Thanks! |
Since this is a blocking issue I'm raising the priority. Will take a look today. Removed Priority-High label. |
CL out for review: https://chromiumcodereview.appspot.com/9487012. Added Started label. |
Fix landed in r4742. Let me know if this fixes the problem for you, Seth. Added Fixed label. |
Confirmed. Thanks a ton! |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/a99abd4..ed56883): ed56883d 2023-01-17 Parker Lougheed Fix, cleanup, and simplify CSS (#3302) http (https://github.com/dart-lang/http/compare/c955c7e..57c53b0): 57c53b0 2023-01-17 Brian Quinlan Fix a NPE that occurs when an error occurs before a response is received. (#852) protobuf (https://github.com/dart-lang/protobuf/compare/dd04535..cc0f287): cc0f287 2023-01-18 Kevin Moore Run non-null-safe tests with Dart 2 (#791) test (https://github.com/dart-lang/test/compare/43fd928..19582a8): 19582a8d 2023-01-19 Nate Bosch Avoid empty `::group::` in Github reporter (#1855) fc4ea341 2023-01-19 Nate Bosch Fix a test to use an still invalid URI (#1856) bd96213a 2023-01-18 Nate Bosch Improve output for collections and long strings (#1852) 9f7de8a2 2023-01-17 Nate Bosch Remove operator extensions (#1847) f790feb0 2023-01-17 Nate Bosch Add Condition abstraction (#1846) webdriver (https://github.com/google/webdriver.dart/compare/b8c7bb5..00c887d): 00c887d 2023-01-17 Devon Carew rev to 3.0.2 in preparation for publishing (#268) Change-Id: I2cbbcdce4fa510cd2458aa05dd45eed01e840c9c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279329 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
The following Dart code:
dom.IDBRequest removeRequest = objectStore.delete(key);
when compiled with Frog, generates this code:
var removeRequest = objectStore.delete_(key);
and fails with this error:
Uncaught NoSuchMethodException : method not found: 'delete_'
The text was updated successfully, but these errors were encountered: