-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListTest - is copyFrom() really the method we want to test? #1953
Labels
area-test
Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
closed-obsolete
Closed as the reported issue is no longer relevant
Comments
We don't have any tests that use copyFrom anymore Added AssumedStale label. |
DartBot
added
Type-Defect
area-test
Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
closed-obsolete
Closed as the reported issue is no longer relevant
labels
Nov 21, 2013
copybara-service bot
pushed a commit
that referenced
this issue
Feb 23, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/dba6f94..e4cdbd6): e4cdbd6f 2023-02-21 Janice Collins Record rendering simplification (#3344) http (https://github.com/dart-lang/http/compare/c13a3f8..1500a71): 1500a71 2023-02-23 Devon Carew contribute a pull request labeler workflow (#875) e2c4e6f 2023-02-21 Brian Quinlan Add a link to cronet_http_embedded from cronet_http. (#874) markdown (https://github.com/dart-lang/markdown/compare/4befe66..ecbffa9): ecbffa9 2023-02-22 Kevin Moore Use latest lints, require Dart 2.19 or later (#524) shelf (https://github.com/dart-lang/shelf/compare/707c8b2..e3cfe79): e3cfe79 2023-02-22 Devon Carew contribute issue templates and a pull request labeler (#332) test (https://github.com/dart-lang/test/compare/e56c643..2cc4144): 2cc4144e 2023-02-22 Nate Bosch Avoid exceptions for iterable getters (#1954) f7fe4f06 2023-02-22 Nate Bosch Include stack trace for exception in has (#1953) ba8e43af 2023-02-22 Nate Bosch Only grab the first failure in softCheck (#1949) 34df652b 2023-02-22 Nate Bosch Flush stdin before test (#1950) ae015ef6 2023-02-22 Nidal Bakir Add Concurrency Testing section to README (#1944) 4e23d036 2023-02-21 Nate Bosch Mention .having and .has in migration guide (#1948) 438c2274 2023-02-21 Nate Bosch Annotate `has` with `@useResult` (#1947) 3ddecafd 2023-02-21 Nate Bosch Add async examples to README (#1946) tools (https://github.com/dart-lang/tools/compare/a53933c..c7518f7): c7518f7 2023-02-22 Elias Yishak Update to regex to look for underscore delimited labels (#12) webdev (https://github.com/dart-lang/webdev/compare/ae7eb80..1e7f9b7): 1e7f9b7 2023-02-22 Anna Gringauze Create copying sdk configuration provider (#1984) 26910ba 2023-02-22 Anna Gringauze Pass SdkLayout to the frontend server (#1986) 784e28b 2023-02-22 Anna Gringauze Remove unnecessary awaits (#1982) 3cbaf37 2023-02-22 Elliott Brooks (she/her) [MV3 Debug Extension] Support Bolt workflow (#1983) 0f893e6 2023-02-22 Anna Gringauze Move project definitions into a separate class (#1975) a942b5f 2023-02-22 Anna Gringauze Add unnecessary_lambdas lint (#1978) 3774cf8 2023-02-21 Anna Gringauze Add 'avoid_void_async' lint (#1977) 705e0ac 2023-02-21 Elliott Brooks (she/her) [MV3 Debug Extension] Show a warning if multiple Dart apps are in a single page (#1976) Change-Id: Iea264a18a154e71cd0990e1363951648bec5ceba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284940 Reviewed-by: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-test
Cross-cutting test issues (use area- labels for specific failures; not used for package:test).
closed-obsolete
Closed as the reported issue is no longer relevant
This issue was originally filed by zundel@google.com
In List tests, there are several references to a method that is not a part of the interface for list:
try {
List a = new List(4);
a.copyFrom(a, null, 1, 1);
} catch (IllegalArgumentException e) {
exception_caught = true;
}
There is an a.setRange() which calls copyFrom.
Now this is perfectly legal, but since it isn't a part of the interface it could change. Also, since the behavior of copyFrom isn't a part o
I would like to annotate this file for static analysis, but use of this method makes it kind of ugly to annotate.
I think the test would be better if it were changed. FYI, we already have a more straightforward test 'FieldDynamicTest' that shows you can reference an undeclared field.
The text was updated successfully, but these errors were encountered: