Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from DOMWindow to Window #2000

Closed
kasperl opened this issue Mar 6, 2012 · 11 comments
Closed

Switch from DOMWindow to Window #2000

kasperl opened this issue Mar 6, 2012 · 11 comments
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-libraries Issues impacting dart:html, etc., libraries

Comments

@kasperl
Copy link

kasperl commented Mar 6, 2012

In light of recent changes to the DOMWindow.idl file, we should consider changing the interface name from DOMWindow to Window.
@rakudrama
Copy link
Member

The WebKit change is http://trac.webkit.org/changeset/108729/trunk/Source/WebCore/page/DOMWindow.idl

interface Window currently exists, and should be being used in application code.

interface DOMWindow has no need to exist and we should work to eliminate it.
We generally have little hacks like subtyping to implement the aliasing of Window and DOMWindow - we would have preferred to have a working typedef to create the alias.

Lets use this issue to figure out the dependent changes in Dartium, dart:html, Frog etc.

cc @vsmenon.

@DartBot
Copy link

DartBot commented Mar 6, 2012

This comment was originally written by antonm@google.com

@vsmenon
Copy link
Member

vsmenon commented Mar 6, 2012

I think we ought to be able to get rid of the dart type name "DOMWindow" altogether. We'll still need some support under the hood in frog to map the JS constructor "DOMWindow" to Dart "Window" to handle older WebKit browsers.

@DartBot
Copy link

DartBot commented Mar 7, 2012

This comment was originally written by podiv...@chromium.org

Dartium changes are pretty straightforward: https://chromiumcodereview.appspot.com/9623003/. The only problem is dart:html tests that start to fail because of Window.typeName: "Unrecognized object Instance of 'WindowImplementation'. Name=Window".

@vsmenon
Copy link
Member

vsmenon commented Apr 13, 2012

Removed Area-UI label.
Added Area-DOM label.

@rakudrama
Copy link
Member

Added this to the M1 milestone.

@iposva-google
Copy link
Contributor

Removed Area-DOM label.
Added Area-HTML label.

@vsmenon
Copy link
Member

vsmenon commented Aug 23, 2012

Removed this from the M1 milestone.
Added this to the M2 milestone.

@blois
Copy link
Contributor

blois commented Nov 30, 2012

Removed this from the M2 milestone.
Added this to the M3 milestone.

@blois
Copy link
Contributor

blois commented Feb 8, 2013

Removed this from the M3 milestone.
Added this to the Later milestone.

@efortuna
Copy link
Contributor

Added AssumedStale label.

@kasperl kasperl added Type-Defect web-libraries Issues impacting dart:html, etc., libraries closed-obsolete Closed as the reported issue is no longer relevant labels Aug 26, 2013
@kasperl kasperl added this to the Later milestone Aug 26, 2013
copybara-service bot pushed a commit that referenced this issue Mar 7, 2023
@devoncarew
[deps] rev async, dartdoc, html, http, http_multi_server, source_map_…
eadfede 
…stack_trace, stream_channel, test, tools, watcher, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/8deaa40..f454380):
  f454380  2023-03-02  Natalie Weizenbaum  Add `StreamExtensions.listenAndBuffer()` (#235)

dartdoc (https://github.com/dart-lang/dartdoc/compare/77d5994..98fa859):
  98fa859c  2023-03-05  dependabot[bot]  Bump cli_util from 0.3.5 to 0.4.0 (#3360)

html (https://github.com/dart-lang/html/compare/0b8025c..08643e9):
  08643e9  2023-03-02  Devon Carew  prep for publishing 0.15.2 (#205)

http (https://github.com/dart-lang/http/compare/1500a71..805a147):
  805a147  2023-03-02  Kevin Moore  Fix some spelling (#884)
  5a2f036  2023-03-02  Kevin Moore  Move to pkg:dart_flutter_team_lints, require Dart 2.19 (#883)
  35b2cef  2023-03-02  Bahaa Fathi Yousef  Corrected the spelling of "Implements" in "/http/lib/src/io_client.dart" (#871)
  bb86cf3  2023-02-27  Brian Quinlan  Provide access to NSURLSession.sessionDescription (#881)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/2cd5355..7bd190c):
  7bd190c  2023-03-06  Kevin Moore  Require Dart 2.19, enable and fix new team lints (#51)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/a60ef54..45ea368):
  45ea368  2023-03-07  Kevin Moore  Require Dart 2.19, use pkg:dart_flutter_team_lints (#35)

stream_channel (https://github.com/dart-lang/stream_channel/compare/0850515..a20ccd4):
  a20ccd4  2023-02-28  Kevin Moore  move to pkg:dart_flutter_team_lints lints, fix code, bump min SDK (#87)

test (https://github.com/dart-lang/test/compare/1307cc5..92da93a):
  92da93a8  2023-03-06  Devon Carew  dogfood the new setup-dart action (#1964)
  e49818ec  2023-03-01  dependabot[bot]  Bump github/codeql-action from 2.2.1 to 2.2.5 (#1963)

tools (https://github.com/dart-lang/tools/compare/28b7be8..a1c3506):
  a1c3506  2023-03-07  Devon Carew  dogfood the new setup-dart action (#25)
  fb46723  2023-03-07  Elias Yishak  Update pubspec.yaml (#24)
  5a72344  2023-03-06  Elias Yishak  Add `DashEvent` for toggling telemetry collection + send event whenever toggled (#23)

watcher (https://github.com/dart-lang/watcher/compare/0ca6638..5968409):
  5968409  2023-03-07  Kevin Moore  blast_repo fixes (#139)
  e8f771a  2023-03-07  Kevin Moore  Require Dart 2.19, use new team lints (#138)

webdev (https://github.com/dart-lang/webdev/compare/deb801b..c007560):
  c007560  2023-03-06  Elliott Brooks (she/her)  [MV3 Debug Extension] Show warning when clicking on debug extension for non Dart app (#2015)
  1a010dc  2023-03-06  Devon Carew  dogfood the new setup-dart action (#2017)
  07743a3  2023-03-06  Anna Gringauze  Fix exception mapping from JS to dart (#2004)
  eb63b31  2023-03-03  Elliott Brooks (she/her)  Create a Dart Debug Extension issue template (#2014)
  85f35d4  2023-03-01  Devon Carew  update publishing automation integration (#2002)
  e748045  2023-02-28  Anna Gringauze  Prepare to release webdev 3.0.1 (#2000)
  5355050  2023-02-27  Elliott Brooks (she/her)  [MV3 Debug Extension] Ignore page reloads for detecting navigation away from app (#1994)
  4e08276  2023-02-27  Anna Gringauze  Prepare to release dwds 18.0.0 (#1993)
  fc54d68  2023-02-27  Anna Gringauze  Fix expression evaluation failures on empty scopes (#1998)
  496a2b4  2023-02-27  Anna Gringauze  Temporarily disable publish verification (#1996)

yaml (https://github.com/dart-lang/yaml/compare/a6d8781..1ad2f49):
  1ad2f49  2023-03-01  Kevin Moore  Require Dart 2.19, migrate to dart_flutter_team_lints, make associated fixes (#138)
  4d369fd  2023-03-01  Kevin Moore  benchmark: fix output.json (#137)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/998eea2..0668eb5):
  0668eb5  2023-03-02  Jonas Finnemann Jensen  Wrap recursively, prepare release (#28)
  a4ff857  2023-03-01  Mohamed Ishad  Update CHANGELOG.md (#37)
  2fdfbdb  2023-02-28  Mohamed Ishad  Fix for issue #23 (#34)
  494ad7c  2023-02-25  MikiPaul  fixed typo (#36)

Change-Id: I101c94575c20fca55c7440e84668413207073a32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287162
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
copybara-service bot pushed a commit that referenced this issue Apr 26, 2023
@devoncarew
[deps] rev mockito, test, webdev
ef0ad39 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

mockito (https://github.com/dart-lang/mockito/compare/28e8eda..f851e17):
  f851e17  2023-04-26  Ilya Yanok  Run CI with Dart 2.19 and dev

test (https://github.com/dart-lang/test/compare/7fab079..c9a3138):
  c9a31388  2023-04-24  Nate Bosch  Remove ignores for undeprecated libraries (#2000)

webdev (https://github.com/dart-lang/webdev/compare/8b42c95..12f2285):
  12f22857  2023-04-25  Elliott Brooks  Run `chrome_proxy_service_test.dart` everyday at 8 AM PST (#2098)

Change-Id: I1c90351b7cde4ead84bb410fa76807b33fdae1a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/298740
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-obsolete Closed as the reported issue is no longer relevant web-libraries Issues impacting dart:html, etc., libraries
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rakudrama @efortuna @vsmenon @blois @kasperl @iposva-google @DartBot