AudioNode.connect arguments don't match spec

[danrubel]

[user feedback]
In dart:html AudioNode.connet() arguments spec, I can ommit "input" and "output". But, In output js by dartc, I can't it.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 3934

[DartBot]

This comment was originally written by jjinux...@google.com

---

I'm looking at (https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioNode-section), and it says:

interface AudioNode {
    void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
    void connect(AudioParam destination, optional unsigned long output = 0);
    ...
}

However, when I look at html_dartium.dart, I see:

void connect(destination, int output, [int input]);

I think those don't match. Looking at the HTML5 Rocks example, they're only passing one argument.

---

Removed Area-Library label.
Added Area-HTML label.
Changed the title to: "AudioNode.connect arguments don't match spec".

[DartBot]

This comment was originally written by jjinux...@google.com

---

Here's a sample: https://github.com/dart-lang/dart-html5-samples/blob/jjinux/webaudio/intro/filter_sample.dart

[blois]

Set owner to @efortuna.
Added this to the M2 milestone.

[efortuna]

@jjinux:
This is actually the correct API. In JavaScript if we just call AudioNode.connect(dest) the other "optional" arguments have the value of undefined. For all APIs in which a user might not pass in in input (where the argument is optional but the default value would be "undefined" in javascript), (see window.alert() for an example), the corresponding Dart API "requires" these parameters and the user can pass in null if they want the same "nothing" behavior.

So when we "merge" the two connect function calls, both have "output" as "optional/undefined" but only one has "input". So input gets marked as "Dart Optional", but you pass in null if you don't want to have an output.

---

Added AsDesigned label.

[DartBot]

This comment was originally written by jjinux...@google.com

---

Thanks for the explanation. I changed all my 0s to nulls, and everything worked correctly under both Dartium and dart2js. Thanks again!

[DartBot]

This comment was originally written by jjinu...@gmail.com

---

Ugh, the behavior of this has reversed and my code broke. I had to change all the nulls back to 0s to get it to work :-/

[efortuna]

Investigating...

it the situation like this: http://code.google.com/p/dart/issues/detail?id=6728 ? If so, in the case it's being used in the bug report, the third argument is not actually optional, and the API is again correct. I haven't closed that bug because I need to write better documentation explaining this. I'll include you on that change when I get it in.

[DartBot]

This comment was originally written by jjinux...@google.com

---

Hey, Emily, thanks for taking a look at this again. Read comments 4, 5, and 6 to fully understand what changed. Thanks!

[efortuna]

(reopening to investigate)

---

Removed this from the M2 milestone.
Added this to the M3 milestone.
Added Accepted label.

[DartBot]

This comment was originally written by jjinux...@google.com

---

Here's the URL for a sample: https://github.com/dart-lang/dart-html5-samples/blob/jjinux/web/webaudio/intro/filter_sample.dart

[efortuna]

closing this bug since this bug: https://code.google.com/p/dart/issues/detail?id=8120 has been opened about the same issue.

---

Removed this from the M3 milestone.
Added this to the M2 milestone.
Added Fixed label.