Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VM fails ConstructorRedirectTest/01 #2103

Closed
peter-ahe-google opened this issue Mar 12, 2012 · 3 comments
Closed

VM fails ConstructorRedirectTest/01 #2103

peter-ahe-google opened this issue Mar 12, 2012 · 3 comments
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@peter-ahe-google
Copy link
Contributor

The test allows calling a non-static instance method from constructor initializers.

@iposva-google
Copy link
Contributor

Set owner to @mhausner.
Added Accepted label.

@DartBot
Copy link

DartBot commented Jun 1, 2012

This comment was originally written by @mhausner


class A {
  var x;
  A(this.x) {}
  A.named(x, int y) : this(x + y);
  A.named2(int x, int y, z) : this.named(staticFun(x, y), z); <<<<<========

  // The following is a bit tricky. It is a compile-time error to
  // refer to this (implicitly or explicitly) from an initializer.
  // When we remove the line with moreStaticFun, staticFun is really a
  // static function and it is legal to call it. This is what will
  // happen in the /none version of this test. However, in /01,
  // staticFun isn't really a static function and should cause a
  // compile-time error.
  static
  moreStaticFun() {} /// 01: compile-time error
  int staticFun(int v1, int v2) {
    return v1 * v2;
  }
}

@DartBot
Copy link

DartBot commented Oct 18, 2012

This comment was originally written by @mhausner


This is fixed at r13790.


Added Fixed label.

@peter-ahe-google peter-ahe-google added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Oct 18, 2012
copybara-service bot pushed a commit that referenced this issue May 9, 2023
…ion, convert, crypto, csslib, ffi, fixnum, glob, html, http_multi_server, http_parser, json_rpc_2, logging, mime, package_config, pool, pub_semver, source_map_stack_trace, sse, stack_trace, stream_channel, string_scanner, term_glyph, test_descriptor, tools, typed_data, web_socket_channel, webdev, yaml, yaml_edit

Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (https://github.com/dart-lang/async/compare/b9ed219..0f368d3):
  0f368d3  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#240)

benchmark_harness (https://github.com/dart-lang/benchmark_harness/compare/e591ec4..f81b042):
  f81b042  2023-05-08  Devon Carew  Update pubspec.yaml (#89)
  1dc07da  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#88)

boolean_selector (https://github.com/dart-lang/boolean_selector/compare/9fd3bae..7eed402):
  7eed402  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#46)

clock (https://github.com/dart-lang/clock/compare/6b2004c..6b9df3e):
  6b9df3e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#50)

collection (https://github.com/dart-lang/collection/compare/bf27520..6abff47):
  6abff47  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#282)

convert (https://github.com/dart-lang/convert/compare/855aeac..b652c00):
  b652c00  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#82)

crypto (https://github.com/dart-lang/crypto/compare/c5403c8..4e9dde1):
  4e9dde1  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#147)

csslib (https://github.com/dart-lang/csslib/compare/44bfbe3..923edf0):
  923edf0  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#178)

ffi (https://github.com/dart-lang/ffi/compare/6d8fa8d..1a859e0):
  1a859e0  2023-05-09  Michael Thomsen  Add topics in pubspec.yaml (#192)

fixnum (https://github.com/dart-lang/fixnum/compare/92ec336..006a130):
  006a130  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#111)

glob (https://github.com/dart-lang/glob/compare/eaa878b..46403be):
  46403be  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#76)

html (https://github.com/dart-lang/html/compare/5d87dc8..593d6f6):
  593d6f6  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#214)

http_multi_server (https://github.com/dart-lang/http_multi_server/compare/e0b5d35..d1fffed):
  d1fffed  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#54)

http_parser (https://github.com/dart-lang/http_parser/compare/bbe37dd..5a33f5f):
  5a33f5f  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#72)

json_rpc_2 (https://github.com/dart-lang/json_rpc_2/compare/5da2705..800843e):
  800843e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#96)

logging (https://github.com/dart-lang/logging/compare/787030a..4779d7e):
  4779d7e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#136)

mime (https://github.com/dart-lang/mime/compare/2d8496d..cd8001e):
  cd8001e  2023-05-09  Lara Schütt  Add `text/markdown` mimeType lookup by extension (#85)
  a0ea506  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#93)

package_config (https://github.com/dart-lang/package_config/compare/7e09db1..f41f92c):
  f41f92c  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#134)

pool (https://github.com/dart-lang/pool/compare/650e5d3..86b4f43):
  86b4f43  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#68)

pub_semver (https://github.com/dart-lang/pub_semver/compare/c3e56d1..6dd1908):
  6dd1908  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#85)

source_map_stack_trace (https://github.com/dart-lang/source_map_stack_trace/compare/08a81a8..09715f9):
  09715f9  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#38)

sse (https://github.com/dart-lang/sse/compare/f947c3d..11ba89e):
  11ba89e  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#83)

stack_trace (https://github.com/dart-lang/stack_trace/compare/9c1b1c5..36fa0e1):
  36fa0e1  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#130)

stream_channel (https://github.com/dart-lang/stream_channel/compare/71d4690..a862e41):
  a862e41  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#90)

string_scanner (https://github.com/dart-lang/string_scanner/compare/f7a656f..3bc6e54):
  3bc6e54  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#57)

term_glyph (https://github.com/dart-lang/term_glyph/compare/b110501..3de5f1b):
  3de5f1b  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#37)

test_descriptor (https://github.com/dart-lang/test_descriptor/compare/aa11162..23e49a2):
  23e49a2  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#51)

tools (https://github.com/dart-lang/tools/compare/6c68bca..62c9604):
  62c9604  2023-05-08  dependabot[bot]  Bump coverallsapp/github-action from 2.0.0 to 2.1.2 (#88)
  fde75bf  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#89)

typed_data (https://github.com/dart-lang/typed_data/compare/d85363d..021f25a):
  021f25a  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#64)

web_socket_channel (https://github.com/dart-lang/web_socket_channel/compare/b28bae6..2630714):
  2630714  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#265)

webdev (https://github.com/dart-lang/webdev/compare/12f2285..fe5b975):
  fe5b9758  2023-05-08  Anna Gringauze  Hide internal implementation details in type objects (#2103)

yaml (https://github.com/dart-lang/yaml/compare/54e8284..1f39ffe):
  1f39ffe  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#142)

yaml_edit (https://github.com/dart-lang/yaml_edit/compare/e05282b..763ca94):
  763ca94  2023-05-08  dependabot[bot]  Bump actions/checkout from 3.5.0 to 3.5.2 (#51)

Change-Id: Ie2414a72f1377775a474ef976c2f9c797ed5b0a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302360
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Development

No branches or pull requests

3 participants