Add the ability to get source for the built-in dart: libraries #2118
Labels
type-enhancement
A request for a change that isn't a bug
Comments
|
This comment was originally written by antonm@google.com Pavel, may you have a look? Set owner to podivilov@google.com. |
|
Anton / Pavel, this issue is not on the critical path for us but would be very nice to have. Please contact me if you need any more background on the issue or would otherwise like to discuss it. |
|
This comment was originally written by podiv...@chromium.org Unfortunately we could not hook into Debugger.getScriptSource. I think we should just send all the scripts to front-end. Luckily inspector now has this cool script navigator. |
|
This comment was originally written by podivilov@google.com Added Fixed label. |
kevmoo
added
type-enhancement
copybara-service bot
pushed a commit
that referenced
this issue
Oct 17, 2023
Revisions updated by `dart tools/rev_sdk_deps.dart`. file (https://github.com/google/file.dart/compare/a18ad1c..7418131): 7418131 2023-10-11 Parker Lougheed Remove now unnecessary glob dependency override (#226) http (https://github.com/dart-lang/http/compare/88ec75e..7240d0a): 7240d0a 2023-10-11 Brian Quinlan Remove obsolete pigeon-generated file (#1032) 827f4fe 2023-10-10 Brian Quinlan Prepare to release cronet 0.4.0 (#1031) native (https://github.com/dart-lang/native/compare/22f4481..757f503): 757f503 2023-10-16 Gabriel Terwesten Use `Logger.detached` for test loggers (#158) sse (https://github.com/dart-lang/sse/compare/e190744..37df57d): 37df57d 2023-10-13 Kevin Moore Enable and fix latest lints (#91) test (https://github.com/dart-lang/test/compare/4341470..ba050ae): ba050ae2 2023-10-13 Nate Bosch Move functions to non-deprecated library (#2120) 96e1ed2d 2023-10-13 Nate Bosch Remove unused href field from error report (#2118) ae7f30e9 2023-10-13 Nate Bosch Make compiler optional in calls to currentPlatform (#2117) tools (https://github.com/dart-lang/tools/compare/92c5c15..ddeccf6): ddeccf6 2023-10-10 Elias Yishak Handling malformed log items in log file (#175) webdev (https://github.com/dart-lang/webdev/compare/7c2c2d7..8d48d5e): 8d48d5ea 2023-10-13 Ben Konyi Bump package:vm_service to ^12.0.0 (#2248) 9102b427 2023-10-13 Anna Gringauze Add evaluation test to webdev to catch issues with runtime debugging API (#2250) 63c7e728 2023-10-12 Elliott Brooks Cider expects messages from a Chrome extension to be a JS object, not a string (#2249) a10bf10e 2023-10-11 Devon Carew regenerate from the latest package:mono_repo (#2247) Change-Id: I5c16c1387b613d1e6076579b26e6b64735097b7e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/330662 Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When stepping from user code into system code (dart: code), we're not able to display the code to the user. I'd be great for them to be able to continue debugging through system code as well as they can through their own code.
Currently we're not getting Debugger.scriptParsed events for dart: scripts, which I think is fine. The location objects that come back for system code all have script ids of "0". This means that the editor can't request script source for these scripts (using the Debugger.getScriptSource call). If the system scripts were assigned unique ids, we could retrive the source and display it to the user. So, we wouldn't get scriptParsed events for the system scripts, but source would be available as needed.
The text was updated successfully, but these errors were encountered: