Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should #{import, library, resource, source} take a stringLiteral? #2158

Closed
DartBot opened this issue Mar 14, 2012 · 3 comments
Closed

Should #{import, library, resource, source} take a stringLiteral? #2158

DartBot opened this issue Mar 14, 2012 · 3 comments
Assignees
@gbracha
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). type-enhancement A request for a change that isn't a bug
Milestone
M1

Comments

@DartBot
Copy link

DartBot commented Mar 14, 2012

This issue was originally filed by rice@google.com

According to the Dart Language Specification, the various '#' tags take a stringLiteral, which allows the use of triple-quoted strings, which may also be raw and/or multiline. Is this intended? From the point of view of being able to scan rapidly for source dependencies, this adds a burden to the scanner while seemingly adding little value for developers.

In addition to limiting the valid tag contents to simple strings, one might also want to restrict the contents of those strings to a limited character set. For example, do we really want to allow a library name or prefix to contain control characters or quotes?
@gbracha
Copy link
Contributor

gbracha commented Mar 14, 2012

I think we may restrict these literals further (we already banned interpolation).

Added Accepted label.

@gbracha
Copy link
Contributor

gbracha commented May 29, 2012

Added this to the M1 milestone.

@gbracha
Copy link
Contributor

gbracha commented Aug 29, 2012

Given library/import syntax reform, this only pertains to URIs. The current rules are appropriate for these - string literal constants without interpolation. This includes raw/multiline/adjacent what have you strings, all of which are probably handy for URIs.

Added Done label.

@DartBot DartBot added Type-Enhancement area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). labels Aug 29, 2012
@DartBot DartBot added this to the M1 milestone Aug 29, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jan 8, 2024
@devoncarew
[deps] rev matcher, mockito, test
315f78e 
matcher (https://github.com/dart-lang/matcher/compare/fcbd361..d9cf4f6):
  d9cf4f6  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#240)
  7ea9047  2023-12-13  Kevin Moore  Update test_api dependency, bump & fix lints, prepare release (#237)
  050fdda  2023-12-13  Kevin Moore  blast_repo fixes (#238)

mockito (https://github.com/dart-lang/mockito/compare/57a7c82..e15e000):
  e15e000  2023-12-14  Sam Rawlins  Bump mockito to 5.4.4
  a2a6566  2023-12-14  Copybara-Service  Merge pull request #726 from provokateurin:chore/deps/test_api-0.7
  bda332c  2023-12-14  jld3103  chore(deps): Allow test_api 0.7
  9bd6fb0  2023-12-12  Paul Berry  Remove mockito pre-null-safety tests.

test (https://github.com/dart-lang/test/compare/43ff5bf..846d73e):
  846d73ee  2024-01-01  dependabot[bot]  Bump actions/upload-artifact from 3.1.3 to 4.0.0 (#2165)
  0ab56790  2024-01-01  dependabot[bot]  Bump actions/stale from 8.0.0 to 9.0.0 (#2167)
  3b960c3e  2024-01-01  dependabot[bot]  Bump github/codeql-action from 2.22.8 to 3.22.12 (#2166)
  30543cae  2023-12-19  Nate Bosch  Add more logging around iframe startup (#2160)
  e56a5e22  2023-12-13  Jacob MacDonald  small cleanup in catch (#2159)
  15b39372  2023-12-13  Jacob MacDonald  handle missing package config files (#2158)
  9667cca8  2023-12-13  Jacob MacDonald  release test_api 7.0.0, test_core 6.0.0, and test 1.25.0 (#2156)
  b3fb1486  2023-12-13  Nate Bosch  Remove support for Internet Explorer (#2114)
  48a2bc3d  2023-12-13  Derek Xu  Update the package:vm_service constraint to allow version 14.x (#2157)

Change-Id: I386444652c47cd14a61665599d86dc3a7669a2fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/345341
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbracha gbracha

Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
M1
Development

No branches or pull requests
4 participants
@kevmoo @gbracha @DartBot @mit-mit