Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use package-spec file in repo/gyp/bots #23565

Closed
sigmundch opened this issue Jun 1, 2015 · 3 comments
Closed

use package-spec file in repo/gyp/bots #23565

sigmundch opened this issue Jun 1, 2015 · 3 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-task A well-defined stand-alone task

Comments

@sigmundch
Copy link
Member

once we have the package-specs implemented in all of our tools, it would be great to use it in our repo and bots and remove the use of symlinks (woo hoo!)

I'm creating this bug to track, but this is blocked on first seeing the features implemented (tracked in issue #23372)
@sigmundch sigmundch added Type-Defect area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Jun 1, 2015
@whesse whesse self-assigned this Jan 27, 2016
@whesse whesse added Priority-Medium type-task A well-defined stand-alone task and removed priority-unassigned labels Jan 27, 2016
@whesse whesse added this to the 1.15 milestone Jan 27, 2016
@whesse
Copy link
Contributor

whesse commented Feb 29, 2016

I have created an initial CL to do this, which currently just creates the .packages file besides the packages directory, and uses it in the tests. I will do more testing of this, and then commit. Removing the packages directory will be a separate cl.

https://codereview.chromium.org/1746743002

@kevmoo kevmoo added P2 A bug or feature request we're likely to work on and removed Priority-Medium labels Mar 1, 2016
@mit-mit
Copy link
Member

mit-mit commented Mar 2, 2016

Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request

@mit-mit mit-mit modified the milestones: 1.16, 1.15 Mar 2, 2016
@kevmoo kevmoo removed this from the 1.16 milestone Apr 19, 2016
whesse added a commit that referenced this issue Sep 15, 2016
@whesse
Use checked-in .package file for building and testing
5d3e356 
Stop creating [build dir]/packages directory with symbolic links.

BUG=#23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
whesse added a commit that referenced this issue Sep 16, 2016
@whesse
Use checked-in .package file for building and testing
61eee9e 
Stop creating [build dir]/packages directory with symbolic links.

BUG=#23565
R=rnystrom@google.com

Committed: 5d3e356

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: 6d238ba
@whesse
Copy link
Contributor

whesse commented Sep 20, 2016

Done, with https://codereview.chromium.org/2346163005

@whesse whesse closed this as completed Sep 20, 2016
whesse added a commit that referenced this issue Sep 20, 2016
@whesse
Remove package root target and support scripts
0695b1d 
BUG=#23565
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2346163005 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P2 A bug or feature request we're likely to work on type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevmoo @sigmundch @whesse @mit-mit