Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: testing package_config on the packagebots #24092

Closed
sethladd opened this issue Aug 14, 2015 · 8 comments
Closed

Request: testing package_config on the packagebots #24092

sethladd opened this issue Aug 14, 2015 · 8 comments
Assignees
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Milestone

Comments

@sethladd
Copy link
Contributor

cc @pq

We'd like to ask that the package_config repo be set up to be tested on our packagebots.

https://github.com/dart-lang/package_config

Thanks!

@sethladd sethladd added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Aug 14, 2015
@sethladd sethladd added this to the 1.12 milestone Aug 14, 2015
@sethladd
Copy link
Contributor Author

cc @whesse is this something you can help with? Thanks!

cc @hterkelsen for FYI

@whesse
Copy link
Contributor

whesse commented Aug 17, 2015

This is one of my goals for this week, to get it running. A run that uses .packages, and no /package directory.

@pq
Copy link
Member

pq commented Aug 17, 2015

Clarifying question: do you want this to run in the packagebot waterfall, in pkg_tested, or both?

@mit-mit
Copy link
Member

mit-mit commented Aug 18, 2015

@sethladd, are there any concrete test cases you have in mind?

@whesse
Copy link
Contributor

whesse commented Aug 18, 2015

Ok, my comment about "goals for this week" was not about this issue. That comment was about making all bots on the package waterfall run using the .package file and no packages/ directory.

On this issue, I will add the package_config package to the package waterfall. I think this particular package would also benefit from being added to the package testing bots on the main waterfall. We added code to support the fact that all users will need to manually delete third_party/pkg/package_config, when we move it to third_party/pkg_tested/package_config, so now we are ready to do this move.

@mit-mit
Copy link
Member

mit-mit commented Aug 18, 2015

Isn't that #24093? We actually don't think that is required in 1.12. We have to make sure that the .package generation works in 1.12, but we are not guranteering that the whole tool chain works without a packaged dir until 1.13. see #24112

@whesse
Copy link
Contributor

whesse commented Aug 18, 2015

OK, continuing discussion about testing of .package on #24093. On this issue, we will add package_config to both the package waterfall and to package testing bots on the main waterfall.

@whesse whesse closed this as completed in e292870 Aug 18, 2015
@sethladd
Copy link
Contributor Author

Thanks @whesse !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Development

No branches or pull requests

4 participants