Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.packages: Run packagebots with a --no-package-symlinks configuration #24093

Closed
2 of 3 tasks
sethladd opened this issue Aug 14, 2015 · 8 comments
Closed
2 of 3 tasks

.packages: Run packagebots with a --no-package-symlinks configuration #24093

sethladd opened this issue Aug 14, 2015 · 8 comments
Assignees
@whesse
Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures status-blocked Blocked from making progress by another (referenced) issue
Milestone
1.19

Comments

@sethladd
Copy link
Contributor

sethladd commented Aug 14, 2015 •
edited by kevmoo
Loading

We'd like to increase confidence in a no-symlinks world. One idea is to run the packagebots with a no-package-symlinks configuration (in parallel with the symlinks config we have now)

Thanks!

Blocked by:
@sethladd sethladd added the area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. label Aug 14, 2015
@sethladd sethladd added this to the 1.12 milestone Aug 14, 2015
@sethladd sethladd mentioned this issue Aug 17, 2015
Closed
12 tasks
@dgrove
Copy link
Contributor

dgrove commented Aug 17, 2015

I believe we don't need this for 1.12 .

@sethladd sethladd modified the milestones: 1.13, 1.12 Aug 17, 2015
This was referenced Aug 18, 2015
Closed
Closed
@whesse
Copy link
Contributor

whesse commented Aug 18, 2015

OK, so we don't do any special testing, just use the SDK as is, without extra options? So pub generates both .package and symlinks, and other tools do what? Do they use the .package if it is there, by default? Shouldn't we be testing something? Like what if the .package file isn't there? Tools besides pub are supposed to still work without a .package file.

@sethladd
Copy link
Contributor Author

So pub generates both .package and symlinks

Yes.

Do they use the .package if it is there

They should, if they are following DEP5 correctly. https://github.com/lrhn/dep-pkgspec/blob/master/DEP-pkgspec.md

Like what if the .package file isn't there

That would be the case if the user didn't upgrade to 1.12, or if they did upgrade to 1.12 but did not run pub get or pub global activate again (which adds the .packages).

Tools besides pub are supposed to still work without a .package file.

Correct. @hterkelsen has some really nice integration tests that test for various scenarios (has a .packages, doesn't have a .packages, etc etc). I'm not sure they are sufficient, but they are definitely necessary and will help catch regressions on the package resolution discovery logic in our various tools.

Starting early in the 1.13 dev cycle, we'll want to start testing with --no-package-symlinks.

@mit-mit mit-mit changed the title Request: run packagebots with a --no-package-symlinks configuration .packages: Run packagebots with a --no-package-symlinks configuration Oct 20, 2015
@kevmoo kevmoo modified the milestones: 1.14, 1.13 Oct 22, 2015
@mit-mit mit-mit modified the milestones: 1.14, 1.15 Jan 29, 2016
@kevmoo kevmoo added the status-blocked Blocked from making progress by another (referenced) issue label Feb 1, 2016
@mit-mit mit-mit modified the milestones: 1.15, 1.16 Mar 1, 2016
@kevmoo kevmoo modified the milestone: 1.16 Apr 19, 2016
@mit-mit mit-mit added this to the 1.19 milestone Aug 1, 2016
@mit-mit
Copy link
Member

mit-mit commented Aug 1, 2016

@kevmoo, how far are we from unblocking this?

@kevmoo kevmoo removed the status-blocked Blocked from making progress by another (referenced) issue label Aug 4, 2016
@kevmoo
Copy link
Member

kevmoo commented Aug 4, 2016

Should be completely unblocked. @whesse running on this?

@mit-mit mit-mit added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Aug 4, 2016
@kevmoo kevmoo mentioned this issue Aug 9, 2016
Closed
@kevmoo
Copy link
Member

kevmoo commented Aug 9, 2016

Emailed @whesse to confirm we are on track for 1.19

whesse added a commit to dart-archive/package-bots that referenced this issue Aug 12, 2016
@whesse
Switch package waterfall to use package spec file, not package root.
f582ad4 
BUG=dart-lang/sdk#24093
R=lrn@google.com, mit@google.com

Review URL: https://chromiumcodereview.appspot.com//2235233004 .
@whesse
Copy link
Contributor

whesse commented Aug 12, 2016

We started using --no-package-symlinks on all builders on the package waterfall, after commit dart-archive/package-bots@f582ad4

The packages using "pub run test" are working fine, the packages using "test.py" are blocked on #27063

@kevmoo kevmoo added the status-blocked Blocked from making progress by another (referenced) issue label Aug 12, 2016
@whesse
Copy link
Contributor

whesse commented Aug 16, 2016

OK, all the packages seem to be running fine, both those running test.dart and those using package:test.

@whesse whesse closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

Labels
area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. P1 A high priority bug; for example, a single project is unusable or has many test failures status-blocked Blocked from making progress by another (referenced) issue
Projects
None yet
Milestone
1.19
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @dgrove @whesse @mit-mit