Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js crashes when .packages contains same package name twice #24122

Closed
harryterkelsen opened this issue Aug 18, 2015 · 0 comments
Closed

dart2js crashes when .packages contains same package name twice #24122

harryterkelsen opened this issue Aug 18, 2015 · 0 comments
Assignees
@harryterkelsen
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). web-dart2js

Comments

@harryterkelsen
Copy link
Contributor

stdout:

The compiler crashed: FormatException: Same package name occured twice. (at offset 56)
#0      parse (package:package_config/packages_file.dart:66:7)
#1      Compiler.setupPackages.<anonymous closure> (file:///usr/local/google/home/het/code/dart/sdk/pkg/compiler/lib/src/apiimpl.dart:403:29)
#2      _RootZone.runUnary (dart:async/zone.dart:1165)
#3      _Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:502)
#4      _Future._propagateToListeners (dart:async/future_impl.dart:585)
#5      _Future._completeWithValue (dart:async/future_impl.dart:376)
#6      _Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:430)
#7      _microtaskLoop (dart:async/schedule_microtask.dart:43)
#8      _microtaskLoopEntry (dart:async/schedule_microtask.dart:52)
#9      _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:96)
#10     _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:149)
@harryterkelsen harryterkelsen self-assigned this Aug 18, 2015
@sethladd sethladd mentioned this issue Aug 19, 2015
Closed
12 tasks
@sigmundch sigmundch mentioned this issue Aug 19, 2015
Closed
harryterkelsen added a commit that referenced this issue Aug 20, 2015
@harryterkelsen @whesse
dart2js: fail gracefully with invalid package config
40c76bb 
Fixes #24118
Fixes #24120
Fixes #24121
Fixes #24122

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//1291283006 .
@kevmoo kevmoo added area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). and removed area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). labels Aug 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harryterkelsen harryterkelsen

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). web-dart2js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @harryterkelsen @floitschG