Implement configuration specific imports

[floitschG]

Implement configuration specific imports [0] behind a flag.
Validate it, and then remove the flag, once the DEP committee has accepted it.

Agreed upon flag (so far): --conditional-directives

The implementation is already underway (checked when committed):

• VM: https://codereview.chromium.org/1380383002/
• dart2js: https://codereview.chromium.org/1388523002/

Still missing: environment variables for the existing libraries:

• VM: issue Set predefined environment variables for existing libraries in the VM #24587
• dart2js: issue Set predefined environment variables for existing libraries in dart2js #24586

Validate implementation by updating pkg/http

• Restructure http/browser_client.dart in http package to avoid dart:mirrors usage (?) http#25

The analysis can be implemented in different phases.

• analyzer: Implement configuration specific imports in the analyzer #24579
  • phase 0
  • phase 1 - no longer planned.
• dart2js (optional): Implement analysis for configuration specific imports in dart2js. #24580 - no longer planned.

Once the DEP committee has accepted:

• remove flag
• Implement in DDC implement configuration specific imports dart-archive/dev_compiler#595
• Validate behavior for summaries and bazel Validate summary generation and bazel model for Config Specific Imports (CSI) #28247

[0] https://github.com/munificent/dep-interface-libraries/blob/master/Proposal.md

[floitschG]

/cc @mit-mit

[bwilkerson]

I now have a CL that will add support in the parser and AST structure for this dep (https://codereview.chromium.org/1406253004/). However, it's a breaking change that will affect many clients of analyzer, so I am hesitant to commit it before we've released 1.13.

[mit-mit]

Now that we are starting 1.14 builds, let's go ahead and land CLs that are ready for this!

[mit-mit]

Looks like the VM changes landed :-). @floitschG, what else remains in 1.14?

[floitschG]

I would like to see the env-variables landed.
I have a patch for dart2js, but things are slightly more complicated in the VM.

[floitschG]

Now available behind a flag.
Here is the Changelog update: 1d2a46e

[mit-mit]

Great! Can we close this bug? And maybe have a new one for removing the flags?

[mit-mit]

Clearing out 1.15 milestone as the last full push to dev has happened. If any changes are required before 1.15 is shipped, please file a merge request

[sethladd]

What is phase 0 and phase 1 mean for analyzer? cc @bwilkerson

[bwilkerson]

I'm not sure, but I think phase 0 was correctly analyzing code based on the interface library and accepting the new syntax, and phase 1 was implementing the verification of the implementation libraries.

[mit-mit]

@bwilkerson is there any remaining critical work in the analyzer?

[bwilkerson]

I honestly don't know. It's been too long since I last looked at it.

Do we have language tests? If so, is analyzer passing them?

I saw an e-mail or issue a few days ago indicating that someone thought analyzer wasn't choosing the right URI to analyze against, but I haven't had time to determine whether that's true.

[lrhn]

I've added another language test. The analyzer is passing in the sense that I had to mark it as giving the warnings that it should, and otherwise accepts the test. I'm not testing the individual warnings, but they look correct to me.

[mit-mit]

Lasse's test is https://codereview.chromium.org/2579253003/ -- looks good to me!

[mit-mit]

@bwilkerson anything else you want to have verified before I close this feature as complete!?

[bwilkerson]

Nope.

[mit-mit]

\o/

Closing (just in time for Christmas)!

[jodinathan]

When can we use it?
Are there any examples?

thanks for this, it is very important =]

[mit-mit]

The test above is probably the best source of information right now; and then you would need to use a 1.22.0-dev.2.0 dev build from https://www.dartlang.org/install/archive.

We will have more docs ready for the 1.22 stable launch.

[stevenroose]

This is awesome! Great work to get this out right before the holidays :)

…

On 16 Dec 2016 17:04, "Michael Thomsen" ***@***.***> wrote: The test above is probably the best source of information right now. We will have more docs ready for the 1.22 launch. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24581 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA0F3PkWum8fjYG9CRpQCwJXGVYKpbVsks5rIraMgaJpZM4GOQEJ> .

[sethladd]

Congrats!

…

On Fri, Dec 16, 2016, 8:12 AM Steven Roose ***@***.***> wrote: This is awesome! Great work to get this out right before the holidays :) On 16 Dec 2016 17:04, "Michael Thomsen" ***@***.***> wrote: > The test above is probably the best source of information right now. We > will have more docs ready for the 1.22 launch. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#24581 (comment)>, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AA0F3PkWum8fjYG9CRpQCwJXGVYKpbVsks5rIraMgaJpZM4GOQEJ > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#24581 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAVZ312HHIz75GVxa8tneykcpPmkLWGks5rIrh1gaJpZM4GOQEJ> .

[skybrian]

What about strong mode summaries for DDC? Will they be generated correctly?

[kevmoo]

That's the last bit we need to figure out...

…

On Fri, Dec 16, 2016 at 9:09 AM, Brian Slesinsky ***@***.***> wrote: What about strong mode summaries for DDC? Will they be generated correctly? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#24581 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABCigQlrYGqEbkPvG9HV9oWcoxlSJyjks5rIsW2gaJpZM4GOQEJ> .

[kevmoo]

Reopening and adding a tracking item around summary validation...

[jodinathan]

Hi,

Is there any date we can expect this?
Using hack to check environment and ifs is getting bigger each day

[lrhn]

This feature is in Dart 2, but restricted to only be able to test against a number of platform specific definitions - currently one per dart: library, so you can test dart.libraries.js to check if JS integration is available.
This allows some build tools to ensure that there is only a fixed known number of different configurations.

[pulyaevskiy]

Just wondering if there are docs available about this feature with some more details?

[anders-sandholm]

Beyond https://github.com/munificent/dep-interface-libraries/blob/master/Proposal.md and @lrhn 's comment above, unfortunately not at this point. Not the answer I'd have liked to give, but currently this is not as well documented as we'd like. Stay tuned.

@lrhn @Sfshaza @kwalrath FYI.