Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove "_uncheckedWhitelist" in code_generator #27255

Closed
vsmenon opened this issue Sep 6, 2016 · 6 comments
Closed

remove "_uncheckedWhitelist" in code_generator #27255

vsmenon opened this issue Sep 6, 2016 · 6 comments
Assignees
@jmesserly
Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures soundness status-blocked Blocked from making progress by another (referenced) issue web-dev-compiler

Comments

@vsmenon
Copy link
Member

vsmenon commented Sep 6, 2016 •
edited by kevmoo
Loading

Complete hack as a work-around until pkg/angular2 is generating strong code.

Blocked by angulardart/angular#48
@vsmenon vsmenon added web-dev-compiler P1 A high priority bug; for example, a single project is unusable or has many test failures soundness labels Sep 6, 2016
@vsmenon vsmenon mentioned this issue Sep 6, 2016
Closed
@vsmenon vsmenon modified the milestone: 1.50 Jan 6, 2017
@vsmenon vsmenon modified the milestone: 1.50 Jan 6, 2017
@vsmenon vsmenon mentioned this issue Jan 24, 2017
Closed
@vsmenon vsmenon added the status-blocked Blocked from making progress by another (referenced) issue label Jan 24, 2017
@vsmenon
Copy link
Member Author

vsmenon commented Jan 24, 2017

Waiting on typed ng.dart templates to remove this whitelist.

@dgrove dgrove modified the milestones: 1.50, 1.23 Feb 14, 2017
@vsmenon vsmenon self-assigned this Mar 9, 2017
@dgrove
Copy link
Contributor

dgrove commented Mar 20, 2017

This is waiting for the new AngularDart code generator, so should be moved to 1.24. Do you agree, @vsmenon ?

@vsmenon vsmenon modified the milestones: 1.24, 1.23 Mar 20, 2017
@vsmenon
Copy link
Member Author

vsmenon commented Mar 20, 2017

Yes, moved it.

kevmoo added a commit that referenced this issue Mar 22, 2017
@kevmoo
Clarify in dev_compiler docs the reason for the angular whitelist hack
2340c8f 
Related to #27255

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2772433002 .
@vsmenon vsmenon assigned leafpetersen and unassigned vsmenon Mar 30, 2017
@dgrove
Copy link
Contributor

dgrove commented May 1, 2017

This seems unlike for 1.24, given that AngularDart hasn't yet switched to the new code generator. Thoughts?

@matanlurey
Copy link
Contributor

We should experiment with how far off we are internally, but yes, won't be in time for 1.24.

@kevmoo kevmoo removed this from the 1.24 milestone May 1, 2017
@vsmenon vsmenon assigned jmesserly and unassigned leafpetersen May 26, 2017
@jmesserly
Copy link

https://codereview.chromium.org/2928483002/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmesserly jmesserly

Labels
P1 A high priority bug; for example, a single project is unusable or has many test failures soundness status-blocked Blocked from making progress by another (referenced) issue web-dev-compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kevmoo @matanlurey @jmesserly @dgrove @vsmenon @leafpetersen