Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default print margin from 100 to 80 per style guidelines #276

Closed
DartBot opened this issue Oct 31, 2011 · 5 comments
Closed

Change default print margin from 100 to 80 per style guidelines #276

DartBot opened this issue Oct 31, 2011 · 5 comments
Assignees

Comments

@DartBot
Copy link

DartBot commented Oct 31, 2011

This issue was originally filed by @chrisbu


What steps will reproduce the problem?

Tools > Preferences > Show Print Margin = 100

Style guidelines on dartlang says "AVOID lines longer than 80 characters" - the editor should help to enforce this

What version of the product are you using? On what operating system?

Dart Editor 0.1.0.201110311319 Build 970

@stevemessick
Copy link
Contributor

I'll handle this one.


Set owner to @stevemessick.
Added Accepted label.

@devoncarew
Copy link
Member

We should consider removing the text field to adjust the value for the print margin - just turn it into a boolean to toggle the (80 char) margin on and off.

@floitschG
Copy link
Contributor

The style-guide is non-binding (and the 80 chars in the guide is just an "AVOID").
So I don't think we should restrict the editor to 80 chars only (especially as I don't see a high maintenance cost in keeping the option).

@stevemessick
Copy link
Contributor

Both good points. For the moment, I'm just changing the default from 100 to 80. Once the formatter is released, I think it makes sense to take another look at this preference to see how best to present the print margin and the formatter line length preferences in as simple a way as possible.

@stevemessick
Copy link
Contributor

Added Fixed label.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants