Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

void arrow functions should allow any rhs type #28939

Closed
4 tasks done
floitschG opened this issue Mar 1, 2017 · 2 comments
Closed
4 tasks done

void arrow functions should allow any rhs type #28939

floitschG opened this issue Mar 1, 2017 · 2 comments
Assignees
@eernstg
Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).

Comments

@floitschG
Copy link
Contributor

floitschG commented Mar 1, 2017 •
edited by lrhn
Loading

It is no longer a static type warning if an arrow function (declared with =>) has a body which is an expression of a type that is not assignable to void.
@floitschG floitschG added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label Mar 1, 2017
@floitschG floitschG added this to the 1.23 milestone Mar 1, 2017
@floitschG floitschG self-assigned this Mar 1, 2017
This was referenced Mar 1, 2017
Closed
Closed
Closed
Closed
@mit-mit mit-mit added the area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). label Mar 2, 2017
@mit-mit mit-mit modified the milestones: 1.24, 1.23 Mar 15, 2017
@mit-mit
Copy link
Member

mit-mit commented Mar 15, 2017

Punting to 1.24 per dart-leads discussion.

@floitschG floitschG assigned eernstg and unassigned floitschG May 9, 2017
@eernstg eernstg modified the milestones: 1.25, 1.24 May 10, 2017
@eernstg
Copy link
Member

eernstg commented May 10, 2017 •
edited
Loading

Punting to 1.25, in agreement with Kasper: The spec part was moved to 1.25 and this meta issue awaits that. The implementation parts are being landed for 1.24.

This was referenced May 18, 2017
Closed
Closed
eernstg added a commit that referenced this issue May 18, 2017
@eernstg
Announced #28939 (void f() => e allows an e of any type) in changelog
9820535 
Addresses sdk issue #29646.

R=floitsch@google.com

Review-Url: https://codereview.chromium.org/2887253003 .
@eernstg eernstg mentioned this issue May 22, 2017
Closed
4 tasks
@eernstg eernstg closed this as completed May 22, 2017
eernstg added a commit that referenced this issue May 24, 2017
@eernstg
Included setters in testing of the void => return-any-type feature.
8aef60a 
The older issue #28939 did not
mention setters. They were already covered in the implementation, so
this CL just adds testing for it.

Addresses issue #29680.

R=floitsch@google.com, johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2899683003 .
@eernstg eernstg mentioned this issue Feb 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eernstg eernstg

Labels
area-language Dart language related items (some items might be better tracked at github.com/dart-lang/language). area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@floitschG @eernstg @mit-mit