Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename BadNumberFormatException -> FormatException #3065

Closed
munificent opened this issue May 15, 2012 · 4 comments
Closed

Rename BadNumberFormatException -> FormatException #3065

munificent opened this issue May 15, 2012 · 4 comments
Assignees
@munificent
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-enhancement A request for a change that isn't a bug

Comments

@munificent
Copy link
Member

I pretty frequently find myself writing classes that have a "parse" constructor, or that otherwise parse and validate text. When an error occurs, they need to throw an exception. Right now, I just write my own one-off exception classes, but that's a chore.

If we rename BadNumberFormatException to the more general FormatException, I could just use that directly.
@DartBot
Copy link

DartBot commented May 15, 2012

This comment was originally written by @seaneagan

Could be used by Date.parse (issue #2868), {int,num,double}.parse (issue #3068), and bool.parse (issue #2870) for a start.

@sethladd
Copy link
Contributor

Added Triaged label.

@alan-knight
Copy link
Contributor

Bob, isn't this done?

Set owner to @munificent.

@munificent
Copy link
Member Author

Added Fixed label.

@munificent munificent added Type-Enhancement area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. labels Sep 5, 2012
@munificent munificent self-assigned this Sep 5, 2012
@kevmoo kevmoo added type-enhancement A request for a change that isn't a bug and removed type-enhancement labels Mar 1, 2016
copybara-service bot pushed a commit that referenced this issue Jun 27, 2022
Roll Dart Documentation Generator from 58348a98b992 to d8195107d3e6 (…
d5fa189 
…1 revision)

https://dart.googlesource.com/dartdoc/+log/58348a98b992..d8195107d3e6

2022-06-27 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.1.12 to 2.1.14 (#3065)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-doc-dart-sdk
Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: dart-ecosystem-gardener@grotations.appspotmail.com
Change-Id: Ib93ce22e459ebc9b77798843acf9949e6327c23e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249948
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munificent munificent

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sethladd @kevmoo @munificent @alan-knight @DartBot