-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elimination of String + in apidoc #3115
Labels
P1
A high priority bug; for example, a single project is unusable or has many test failures
Comments
Set owner to @munificent. |
DartBot
added
Type-Defect
P1
A high priority bug; for example, a single project is unusable or has many test failures
labels
May 24, 2012
copybara-service bot
pushed a commit
that referenced
this issue
Sep 28, 2021
Changes: ``` > git log --format="%C(auto) %h %s" 15a46117da29cc572fba620241c83a2117cdae09..a817863ee93241ff36fce6856c6d12fd8fde0907 a817863e Use pool for file reading (#3156) 59237e29 Don't ask packageLister for availabe versions (#3151) f2f86c01 Fix analyze errors (#3148) 39c9779c Environment credentials support (#3115) f0020823 Improved handling for authentication errors (#3120) 1bb9f923 Migrate ignore.dart to null-safety (#3142) ``` Change-Id: I01d6637e3de8e523596394383393f5eda1a728c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214804 Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Jonas Jensen <jonasfj@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Aug 10, 2022
…4 revisions) https://dart.googlesource.com/dartdoc/+log/f419695f57c5..8ee30225e2d8 2022-08-10 srawlins@google.com Move to analyzer 4.5.0 (#3115) 2022-08-10 srawlins@google.com Stop using eol_at_end_of_file (#3114) 2022-08-10 106621169+klr981@users.noreply.github.com Dark Mode: Landed changes in this PR (#3113) 2022-08-10 srawlins@google.com Move to analyzer 4.4.0 (#3112) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-doc-dart-sdk Please CC dart-ecosystem-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To file a bug in Dart Documentation Generator: https://github.com/dart-lang/dartdoc/issues To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: dart-ecosystem-gardener@grotations.appspotmail.com Change-Id: If54ebd9e0e1f050b2db72da5d53418b87ce67be5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254520 Commit-Queue: Devon Carew <devoncarew@google.com> Commit-Queue: DEPS Autoroller <dart-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by: Devon Carew <devoncarew@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by @mhausner
Running the VM without support for String + operator causes apidoc to fail.
See change 7718
Log file:
http://chromegw.corp.google.com/i/client.dash/builders/dartc-linux-debug/builds/3130/steps/build/logs/stdio
To test, run the VM with allow_string_plus set to false (either on command line or change the default in vm/parser.cc).
The text was updated successfully, but these errors were encountered: