-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dart2js generated code fails on safari #3288
Comments
Can you provide a simple test case that fails? We know of a few issues with the browser compatibility of the dart2js output that we're fixing, but it would be nice to know if this issue is already covered by that work. Added Area-Dart2JS, NeedsInfo labels. |
This comment was originally written by @bp74 Could be the same problem as described in issue #3025. The problem is the requestAnimationFrame method which works in frog but not in Dart2Js. The JavaScript code is: Isolate.$defineClass("Closure", "Closure6", ["box_0"], { |
The Dart code would be helpful. |
This comment was originally written by @bp74 Just tested it with Dart Editor Build 8052, problem is still the same. Dart code from issue #3025: void main() { bool onAnimationFrame(var currentTime) { |
This comment was originally written by @bp74 I finally found the "Error Console" in Safari :) |
Removed Priority-Medium label. |
Thank you, Bernhard! |
This comment was originally written by @bp74 Tested with Dart Editor 8124 and it works now! Thanks. |
This comment was originally written by ngeoffray@google.com Added Fixed label. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/9ed196f..29a1bbf): 29a1bbf8 2023-01-04 Sam Rawlins Migrate documentation_comment_test to be reflective (#3288) string_scanner (https://github.com/dart-lang/string_scanner/compare/6ddab2c..c58618d): c58618d 2023-01-06 dependabot[bot] Bump actions/checkout from 3.2.0 to 3.3.0 (#52) webdev (https://github.com/dart-lang/webdev/compare/8795ca5..49f97b8): 49f97b8 2023-01-06 Parker Lougheed Replace deprecated implicit-casts option with strict-casts option (#1863) 940c0ee 2023-01-06 Elliott Brooks (she/her) Set a debug key for the injected client and Dart Debug Extension SSE clients (#1872) ae3e2ea 2023-01-06 Elliott Brooks (she/her) [MV3] Dart Debug Extension supports cross-extension communication with AngularDart DevTools (#1866) 0662af9 2023-01-06 Anna Gringauze Fix error message on dds failure2 (#1865) 4f62035 2023-01-06 Elliott Brooks (she/her) Can launch embedded Dart Debugger & Flutter Inspector (#1829) 36fa973 2023-01-05 Elliott Brooks (she/her) Refactor `TestContext` constructor for clarity (#1844) 57776a0 2023-01-04 Elliott Brooks (she/her) Use latest version of `package:sse` in the MV3 Debug Extension (#1859) Change-Id: Ib97239b4f453238572dcccb9a0f81e4f1e969a04 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278683 Commit-Queue: Konstantin Shcheglov <scheglov@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This issue was originally filed by @pjako
I wrote a simple app in dart with canvas and tested it in safari.
This appeared:
TypeError: 'undefined' is not a function (evaluating 'this.box_0.closure_1.$call$0()')
the app runs fine on safari with frog.
The text was updated successfully, but these errors were encountered: