-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WheelEvent not working in IE9 when compiled with dart2js #3317
Comments
This comment was originally written by ngeoffray@google.com Comment from Bernhard (not sure why it's not showing up here): Just testet it with the supported version of Dart Editor (Build 8124) and now it works. There are just 16 revisions between those two versions but it seems we are lucky and this issue is not a problem anymore Added Area-Dart2JS, Fixed labels. |
This comment was originally written by @bp74 Sorry it was my fault, i made a mistake at testing. |
This comment was originally written by ngeoffray@google.com Re-opening then :) Added Triaged label. |
Removed Priority-Medium label. |
This could be a DOM issue (like issue #3152). CC'ing Stephen, but it would be great if you could take a look, Nicolas, and figure out if this is a dart2js issue or a DOM issue. cc @rakudrama. |
This comment was originally written by ngeoffray@google.com Stephen, could that be the same problem than: |
It looks like this is because the getters (get$pageX, get$pageY) that we add to Object.prototype aren't visible on WheelEvent. It probably worked with frog because the event parameter is typed with WheelEvent. Set owner to @rakudrama. |
I see get$pageX as expected, but it does not dispatch to the expected getter. Object.prototype.toString.call(event$) |
Should be fixed by r8582 / r8585. |
Verified from latest download. Added Verified label. |
dartdoc: 494a6bed 2023-02-02 Sam Rawlins Bump markdown dep to a pre-release of 7.0.0 (#3321) ad6f1612 2023-02-02 Devon Carew introduce an environmentProvider abstraction (#3324) d0b73000 2023-02-02 Sam Rawlins Prepare testing code for some upcoming Warnings (#3322) 936a7888 2023-02-01 Sam Rawlins Add text about front-end manual testing (#3286) cbee812d 2023-02-01 Sam Rawlins Avoid renaming generator params (#3316) bcaa0349 2023-02-01 Sam Rawlins Privatize Library.sdkLib and move getClassByName (#3317) af32def5 2023-01-31 dependabot[bot] Bump github/codeql-action from 2.1.39 to 2.2.1 (#3313) 528e97da 2023-01-31 dependabot[bot] Bump actions/cache from 3.2.3 to 3.2.4 (#3312) 54020672 2023-02-01 Parker Lougheed Begin changelog for next release after 6.1.5 (#3315) markdown: f51c24c 2023-02-01 Zhiguang Chen Prepend a line ending if the p tag is removed and there is an element before it in a *tight* list (#513) dd3e3a1 2023-01-31 dependabot[bot] Bump dart-lang/setup-dart from 1.3 to 1.4 (#510) 5f25fc9 2023-01-31 dependabot[bot] Bump actions/checkout from 3.2.0 to 3.3.0 (#511) 54266b2 2023-01-31 Kevin Moore Prepare to release v7.0.0 (#509) d6ceff9 2023-01-31 Zhiguang Chen Add line endings before HTML blocks (#508) ccd3c8b 2023-01-29 Zhiguang Chen Rewrite link reference definitions (#506) e8f84dc 2023-01-24 Kevin Moore Update GFM to 0.29.0.gfm.7 (#507) 93f67b0 2023-01-20 Zhiguang Chen Add an `enableTagfilter` option to `HtmlRenderer` to eanble GFM `tagfilter` extension (#447) d110770 2023-01-13 Zhiguang Chen Rewrite SetextHeaderSyntax (#500) c1b9bc6 2023-01-09 Sam Rawlins Migrate from no-implicit-casts to strict-casts (#504) 3e78c08 2023-01-01 dependabot[bot] Bump actions/checkout from 3.0.2 to 3.2.0 (#501) 417747f 2022-12-15 Zhiguang Chen Refactor list syntax (#499) 30ec05f 2022-11-29 Zhiguang Chen Do not escape single quote(apostrophe) inside code (#498) c3d1136 2022-11-29 Zhiguang Chen introduce a Line class (#494) Change-Id: I9d971b927b72500ab84cce461a60fe1a86818e2e Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281543 Reviewed-by: Samuel Rawlins <srawlins@google.com> Commit-Queue: Devon Carew <devoncarew@google.com>
This issue was originally filed by @bp74
What steps will reproduce the problem?
void main() {
document.body.on.mouseWheel.add((WheelEvent event) {
try {
print(event.pageX);
print(event.pageY);
}
catch(final e) {
print("Error");
}
});
}
What is the expected output? What do you see instead?
You should be able to receive the WheelEvent and access the properties. In IE9 you get an error that the getter is not available. I started the debugger which is integrated in IE9 and see that the "event" variable has all the fields you expect. But still you can't get it.
The same code compiled with frog works. I also tested events like MouseEvent for "onMouseMove" and those events work fine for dart2js and frog. It's just the WheelEvent.
What version of the product are you using? On what operating system?
Dart Editor Build 8108 32 bit, Windows 7 64 bit.
The text was updated successfully, but these errors were encountered: