Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtins.dart has no return in _setPackageRoot #3424

Closed
DartBot opened this issue Jun 7, 2012 · 3 comments
Closed

builtins.dart has no return in _setPackageRoot #3424

DartBot opened this issue Jun 7, 2012 · 3 comments
Assignees
@iposva-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.

Comments

@DartBot
Copy link

DartBot commented Jun 7, 2012

This issue was originally filed by sunw...@gmail.com

String _setPackageRoot(String packageRoot) {
  // TODO(mattsh) - refactor windows drive and path handling code
  // so it can be used here if needed.
  _packageRoot = packageRoot;
}
@anders-sandholm
Copy link
Contributor

cc @turnidge.
Added Area-VM, Triaged labels.
_Changed the title to: "builtins.dart has no return in setPackageRoot".

@iposva-google
Copy link
Contributor

_setPackageRoot should not return anything and be either typed void or nothing.

Set owner to @iposva-google.
Added Accepted label.

@iposva-google
Copy link
Contributor

Added Fixed label.

@DartBot DartBot added Type-Defect area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels May 29, 2013
copybara-service bot pushed a commit that referenced this issue Jun 13, 2022
@sigurdm
Bump pub to c4e9ddc888c3aa89ef4462f0c4298929191e32b9
2aa637a 
Changes:
```
> git log --format="%C(auto) %h %s" 51435ef..c4e9ddc
 https://dart.googlesource.com/pub.git/+/c4e9ddc8 Extend retries for file-ops on windows (#3451)
 https://dart.googlesource.com/pub.git/+/6aeb1795 Upgrade package:lints to 2.0.0 (#3445)
 https://dart.googlesource.com/pub.git/+/73ea9a98 Roll tar to 0.5.5+1 (#3447)
 https://dart.googlesource.com/pub.git/+/2dc887fe Add env var for writing golden files (#3222)
 https://dart.googlesource.com/pub.git/+/764500b8 List all files in pub publish (#3440)
 https://dart.googlesource.com/pub.git/+/0b52e6a8 Remove debug print (#3441)
 https://dart.googlesource.com/pub.git/+/ea070238 Merge pull request #3443 from jonasfj/master
 https://dart.googlesource.com/pub.git/+/bffd1267 Merge branch 'cherry-pick-for-2.17.2'
 https://dart.googlesource.com/pub.git/+/c66381c5 Make `name` field of `_UserInfo` nullable. Fix #3424 (#3442)
 https://dart.googlesource.com/pub.git/+/cecc8e3c Handle broken response from userinfo_endpoint (#3427)
 https://dart.googlesource.com/pub.git/+/6c635040 Make `name` field of `_UserInfo` nullable. Fix #3424 (#3442)
 https://dart.googlesource.com/pub.git/+/6f20a94b Handle missing pubspec.lock in dependency_services list (#3439)
 https://dart.googlesource.com/pub.git/+/0ad17e84 Handle broken response from userinfo_endpoint (#3427)
 https://dart.googlesource.com/pub.git/+/153ef061 `pub add` create top-level attribute in block-style if possible. (#3423)
 https://dart.googlesource.com/pub.git/+/3b96f910 Handle error code 183 on windows (#3426)
 https://dart.googlesource.com/pub.git/+/9eb6428c Ignore `pubspec_overrides.yaml` for `publish` command (#3419)

```

Diff: https://dart.googlesource.com/pub.git/+/51435efcd574b7bc18d47a5dd620cb9759dea8f8~..c4e9ddc888c3aa89ef4462f0c4298929191e32b9/
Change-Id: I6dacb3e95c6399d3fb5cf340b5d0e5cded270684
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247962
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
copybara-service bot pushed a commit that referenced this issue May 30, 2023
@jcollins-g
[deps] rev dartdoc, http, lints, logging, tools, webdev
2a56918 
Revisions updated by `dart tools/rev_sdk_deps.dart`.  rev_sdk_deps is changed to default to `main` if no branch is found, as `origin` doesn't seem to work for impacted repos (e.g. csslib).

dartdoc (https://github.com/dart-lang/dartdoc/compare/1d94484..950898f):
  950898f5  Tue May 30 11:18:38 2023 -0700  Janice Collins  Reintroduce remote linking file type assumption (#3425)
  ef552992  Tue May 30 09:49:16 2023 -0700  Sam Rawlins  Refactor search ranking (#3424)

http (https://github.com/dart-lang/http/compare/8a4a4a6..18a43a2):
  18a43a2  Tue May 30 09:44:24 2023 -0700  Brian Quinlan  Fix the failing cupertino_http tests (#949)

lints (https://github.com/dart-lang/lints/compare/4236c43..edc28ed):
  edc28ed  Tue May 30 11:56:29 2023 -0500  Parker Lougheed  Add topics to the pubspec file (#122)

logging (https://github.com/dart-lang/logging/compare/7ba155a..f2fe2ac):
  f2fe2ac  Tue May 23 15:01:13 2023 -0700  Jacob MacDonald  prep for release (#140)
  ce41605  Mon May 22 10:14:28 2023 -0700  Devon Carew  blast_repo fixes (#142)

tools (https://github.com/dart-lang/tools/compare/b90a7e8..d723a55):
  d723a55  Tue May 30 11:02:27 2023 -0700  Devon Carew  Update pull_request_label.yml (#107)

webdev (https://github.com/dart-lang/webdev/compare/4b69f1d..d442fa8):
  d442fa89  Tue May 30 14:36:53 2023 -0400  Anna Gringauze  Check for new events more often in batched stream. (#2123)

Change-Id: I9e8905363ee51462529341bfba268504336d90e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/306314
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iposva-google iposva-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anders-sandholm @iposva-google @DartBot