Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer doesn't allow super static member namespace conflicts #34331

Closed
MichaelRFairhurst opened this issue Aug 31, 2018 · 1 comment
Closed

Analyzer doesn't allow super static member namespace conflicts #34331

MichaelRFairhurst opened this issue Aug 31, 2018 · 1 comment
Assignees
@scheglov
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Milestone
Dart 2.1.1

Comments

@MichaelRFairhurst
Copy link
Contributor 

class A {                                                                        
  static var a;                                                                            
}                                                                                
                                                                                 
class C extends A {                                                              
  var a; // this should fail                       
}

from test check_member_static_test/01

CFE does the correct thing here, so I'm making this a P2, and adding to Dart2.1.
@MichaelRFairhurst MichaelRFairhurst added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Aug 31, 2018
@MichaelRFairhurst MichaelRFairhurst added this to the Dart2.1 milestone Aug 31, 2018
@scheglov scheglov self-assigned this Sep 4, 2018
@scheglov
Copy link
Contributor

scheglov commented Sep 4, 2018

https://dart-review.googlesource.com/c/sdk/+/72903

dart-bot pushed a commit that referenced this issue Sep 4, 2018
@scheglov
Stop reporting CONFLICTING_INSTANCE_GETTER_AND_SUPERCLASS_MEMBER and …
48a1504 
…CONFLICTING_INSTANCE_SETTER_AND_SUPERCLASS_MEMBER.

These errors were removed from the spec.
See also #33235

R=brianwilkerson@google.com

Bug: #34331
Change-Id: Ibc675aa48165300ddac32a8d6ddef4d84d41952a
Reviewed-on: https://dart-review.googlesource.com/72903
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov scheglov closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
Dart 2.1.1
Development

No branches or pull requests
3 participants
@scheglov @MichaelRFairhurst @bwilkerson