Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create analyzer-stable branch #35806

Closed
whesse opened this issue Jan 30, 2019 · 15 comments
Closed

Create analyzer-stable branch #35806

whesse opened this issue Jan 30, 2019 · 15 comments
Assignees
@whesse @athomas
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.

Comments

@whesse
Copy link
Contributor

whesse commented Jan 30, 2019

Retire the "analyzer-0.33" branch, and instead create a branch called "analyzer-stable" with the permissions the analyzer-0.33 branch used to have (push and code review access for the analyzer team IIRC). And then point the analyzer branch builders (and the console page) to it. @stereotype441
@whesse whesse added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes. labels Jan 30, 2019
@whesse
Copy link
Contributor Author

whesse commented Jan 30, 2019

This sounds OK to me, if you need stabilization on a different schedule and release policy than the SDK as a whole (which you do).
If it were a separate repo, then it would be just a master and stable branch on that repo, but the setup is not really more complicated with it in the SDK.
We just make the analyzer-stable branch, and the builders on it, and you stabilize on that branch and publish to pub.

@whesse
Copy link
Contributor Author

whesse commented Jan 30, 2019

If you don't use the "analyzer" branch anymore (it is now locked, with no new commits allowed), we could use that one. That one already has mirroring set up so it appears on github as well. If you don't want it to appear on github, it is just as easy to create the analyzer-stable branch on Gerrit, and give you (dart-team) the right permissions, and switch the builders to it. Let me know which you prefer.

@stereotype441
Copy link
Member

If you don't use the "analyzer" branch anymore (it is now locked, with no new commits allowed), we could use that one. That one already has mirroring set up so it appears on github as well. If you don't want it to appear on github, it is just as easy to create the analyzer-stable branch on Gerrit, and give you (dart-team) the right permissions, and switch the builders to it. Let me know which you prefer.

I thought about that, but I was concerned that it would lead to confusion, since previously the "analyzer" branch was ahead of master, and the branch I want now is meant to be behind master. So I'd rather we go ahead create the new analyzer-stable branch as discussed earlier.

I don't think there's any need to mirror the new branch to github.

@stereotype441
Copy link
Member

Please base the branch on commit 3cb16d2, thanks!

@psycry
Copy link

psycry commented Jan 30, 2019

Not sure if this is related to what I'm seeing but this does seem to coincide with me starting to have this issue this morning:

#35810

beta branch but I've tried it on others, it may be something causing a plugin incompatibility with IntelliJ

@athomas
Copy link
Member

athomas commented Jan 30, 2019

The branch exists now:
https://dart.googlesource.com/sdk/+/refs/heads/analyzer-stable

@stereotype441 re-open if anything doesn't work.

@psycry This issue is unrelated to your issue.

@athomas athomas closed this as completed Jan 30, 2019
@athomas
Copy link
Member

athomas commented Jan 30, 2019

Oh, missed the part about moving the builders over.

@athomas athomas reopened this Jan 30, 2019
dart-bot pushed a commit that referenced this issue Jan 31, 2019
@whesse
[infra] Switch analyzer-0.33 builders and console to analyzer-stable
d74aa9b 
Bug: #35806
Change-Id: I05163073eabea10e01009119a3361b6ff0c5ca06
Reviewed-on: https://dart-review.googlesource.com/c/91741
Reviewed-by: William Hesse <whesse@google.com>
@whesse
Copy link
Contributor Author

whesse commented Jan 31, 2019

Because the recipes have changed (a gclient getdep to fetch the co19 version assumes it is a cipd checkout), the co19 checkout in the analyzer branch must be changed to the new co19 cipd package.
This may also hit any stable patch release we do for the main Dart SDK.

@whesse
Copy link
Contributor Author

whesse commented Jan 31, 2019

co19 fix worked. I also approved the test results of this commit (accidentally), but this sounds like what you wanted, based on our discussion of auto-approval. All the test failures are visible in the test results for commit 4626ec65cc787d77862fc4066a1f0dc26934569a

@stereotype441
Copy link
Member

Great! Thanks so much for getting this all set up!

@stereotype441
Copy link
Member

Are try bots expected to work on the branch? I just tried running a CL through the try bots and got "Patch Failure" from most of the bots: https://dart-review.googlesource.com/c/sdk/+/91761

It's not a huge deal if this isn't expected to work; we can always just use the post-submit bots to verify that everything is ok. But I wanted to make sure you were aware of it if it's expected to work :)

@stereotype441
Copy link
Member

@whesse ping! It would be nice to know if try bots are expected to work on this branch.

@athomas
Copy link
Member

athomas commented Feb 7, 2019

It obviously doesn't work right now but we don't know yet if it's just a configuration issue or something that just isn't supported, yet.

@stereotype441
Copy link
Member

It obviously doesn't work right now but we don't know yet if it's just a configuration issue or something that just isn't supported, yet.

Ok, thanks!

@athomas
Copy link
Member

athomas commented Sep 18, 2020

Closing, unlikely we will work on this in the near future.

@athomas athomas closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whesse whesse

@athomas athomas

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. area-infrastructure Use area-infrastructure for SDK infrastructure issues, like continuous integration bot changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stereotype441 @whesse @athomas @psycry