-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect benchmarks and improve FFI performance #36247
Comments
https://github.com/santetis/libsodium.dart contains a crypto benchmark |
Note to self. Loop invariant code motion should garbage collect the Pointer object too early, as that would call finalizers too early. See TypedData, which has the same issue. |
To scope this for the MVP release: we will understand the performance of FFI operations and implement any "low-hanging" optimisations. |
Arm32 benchmarks on Linux are blocked by #36309. |
Issue: #36247 Change-Id: I81f4cb1d34bc25efe6bc4c2d14615356ac52262f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106906 Commit-Queue: Daco Harkes <dacoharkes@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com> Reviewed-by: Martin Kustermann <kustermann@google.com>
Adds micro benchmarks to measure low level (1) C memory reads and writes from Dart and (2) calls from Dart into C. This CL also adds a macro benchmark to measure overall performance using BoringSSL to digest data. The shared libraries are precompiled for Linux and live in cipd packages. The benchmarks run on all hardware architectures (with the exception of Linux'es hardfp on Arm32: #36309). Issue: #36247 Change-Id: I8dfb30cc66a26a2942bb09194c5eb0da0b6ca1b5 Cq-Include-Trybots: luci.dart.try:benchmark-linux-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108724 Commit-Queue: Daco Harkes <dacoharkes@google.com> Reviewed-by: Jonas Termansen <sortie@google.com> Auto-Submit: Daco Harkes <dacoharkes@google.com>
We need benchmarks for FFI callbacks also. |
Closing in favor of the new issues. |
Pointer.store
andPointer.load
in ILPointer.store
andPointer.load
in IL (moved to [vm/ffi] Pointer operation optimizations #38172)The text was updated successfully, but these errors were encountered: